search

Terrastories / terrastories

Terrastories is a geostorytelling application for mapping, managing and sharing place-based stories.
https://terrastories.app
MIT License
319 stars 157 forks source link

[Test] Add test for places_controller #282

Closed MxOliver closed 4 years ago

MxOliver commented 5 years ago

Add tests for the places_controller (app/controllers/places_controller.rb)

rgenchev commented 5 years ago

Can I work on this? :)

midhunkrishna commented 5 years ago

@rgenchev Are you working on this?

rgenchev commented 5 years ago

Yup :)

kalimar commented 5 years ago

@midhunkrishna are you comfortable with Javascript tests? I'm getting ready to drop a bunch of issues for those.

midhunkrishna commented 5 years ago

@kalimar I am. Please go ahead. (Apologies for the late reply. I was on vacation until yesterday)

rgenchev commented 5 years ago

@midhunkrishna @kalimar, I have a question. I configured FactoryBot and added tests for StoriesController in https://github.com/Terrastories/terrastories/pull/333. The PR is not merged yet but I'll need the FactoryBot configuration and fixtures in this branch. What advice can you give me in this situation? What would be the cleanest solution? Thanks in advance! :)

MxOliver commented 5 years ago

@rgenchev I will take a look at that PR and see if we can get it merged tonight, that was you won't have to deal with conflicts.

Edit: I just approved and merged #333 so you are all set

rgenchev commented 5 years ago

I created https://github.com/Terrastories/terrastories/pull/362 that should close this issue.