Terrastories / terrastories

Terrastories is a geostorytelling application for mapping, managing and sharing place-based stories.
https://terrastories.app
MIT License
319 stars 157 forks source link

[Rails] Let's add Community and Language fields as filter options; hide them if there are no values #688

Closed rudokemper closed 2 years ago

rudokemper commented 3 years ago

Context:

There are two fields in Terrastories that we are currently not using on the front end: community (in the Speaker model) and language (in the Story model). These could be set as filters for the stories.

Let's add these to the filters menu, but, make it so that they don't show up if there are no values set within the community.

(That is, if there are no stories that have any content in language, Language does not show up as one of the filter menu options.)

Acceptance criteria:

noelledusahel commented 3 years ago

@rudokemper i can try this one next!

rudokemper commented 3 years ago

All yours :)

rudokemper commented 2 years ago

Hi @noelledusahel ! Did you still want to work on this one? Just checking in :)

noelledusahel commented 2 years ago

Hi @noelledusahel ! Did you still want to work on this one? Just checking in :)

@rudokemper I put this PR up last October... I dont think it got a review since https://github.com/Terrastories/terrastories/pull/702

rudokemper commented 2 years ago

Oh! My bad @noelledusahel I didn't realize this PR also addressed this issue. We'll get it reviewed as soon as possible; our stewards team is a little small at the moment (and still mostly volunteer). Sorry about that.