Terrastories / terrastories

Terrastories is a geostorytelling application for mapping, managing and sharing place-based stories.
https://terrastories.app
MIT License
319 stars 157 forks source link

[UI] Height of StoryList view exceeds viewport in mobile #789

Closed rudokemper closed 2 years ago

rudokemper commented 2 years ago

Describe the bug The height of the mobile StoryList view exceeds the viewport in mobile. In the screenshot below (Samsung Galaxy A71), you can see that the bottom content of the StoryList Hello username (Back to Welcome Page) Admin Page is not shown.

Screenshot_20220729-084243_Chrome

This especially becomes an issue for phones that automatically scroll down on the page when a dropdown is selected. I've seen this on one device where they selected something for the second filter, and it scrolled down on the StoryList thereby hiding the X on the top to return to the map view.

To Reproduce Steps to reproduce the behavior:

  1. On a mobile device, go to https://our.terrastories.io and log in with username terrastories-developer@terrastories.io and password terrastories.
  2. Enter Site
  3. Press on the arrow button on the top left to bring the StoryList into view.
  4. See the bug

Expected behavior The bottom content of the StoryList Hello username (Back to Welcome Page) Admin Page is always shown on the bottom regardless of Viewport size.

asheerrizvi commented 2 years ago

@rudokemper I can pick this up if it's still up for grabs.

rudokemper commented 2 years ago

@asheerrizvi sure thing! Will assign you. Thanks! :)

asheerrizvi commented 2 years ago

hey @rudokemper I was trying to setup terrastories on my local but I keep running into this error when I am trying to run docker-compose build. Got any idea about this?

=> ERROR [terrastories_e2e 7/9] RUN bundle install

➜  terrastories git:(master) docker-compose build
[+] Building 16.8s (17/26)
 => [terrastories internal] load build definition from Dockerfile                                                                                                          0.0s
 => => transferring dockerfile: 32B                                                                                                                                        0.0s
 => [terrastories_e2e internal] load build definition from Dockerfile                                                                                                      0.0s
 => => transferring dockerfile: 32B                                                                                                                                        0.0s
 => [terrastories internal] load .dockerignore                                                                                                                             0.0s
 => => transferring context: 35B                                                                                                                                           0.0s
 => [terrastories_e2e internal] load .dockerignore                                                                                                                         0.0s
 => => transferring context: 2B                                                                                                                                            0.0s
 => [terrastories internal] load metadata for docker.io/library/ruby:2.5.9-alpine                                                                                          1.1s
 => [terrastories_e2e internal] load metadata for docker.io/library/ruby:2.5.1-slim                                                                                        1.1s
 => CACHED [terrastories 1/9] FROM docker.io/library/ruby:2.5.9-alpine@sha256:1aa1dbab746b3dc5d102567a3f91b04023bc61da29bbb36efe1280e9d90074f7                             0.0s
 => [terrastories internal] load build context                                                                                                                             0.0s
 => => transferring context: 23.42kB                                                                                                                                       0.0s
 => CANCELED [terrastories 2/9] RUN apk --no-cache add --update     build-base     nodejs     yarn     tzdata     postgresql-dev     postgresql-client     postgresql     15.6s
 => [terrastories_e2e 1/9] FROM docker.io/library/ruby:2.5.1-slim@sha256:5a88bb901da277f0b4fa73b57549b14fb46ae83fb6e6ceb3bbd5df382192676f                                  0.0s
 => [terrastories_e2e internal] load build context                                                                                                                         0.0s
 => => transferring context: 491B                                                                                                                                          0.0s
 => CACHED [terrastories_e2e 2/9] RUN apt-get -y update &&   apt-get install --fix-missing --no-install-recommends -qq -y   build-essential                                0.0s
 => CACHED [terrastories_e2e 3/9] RUN gem install bundler                                                                                                                  0.0s
 => CACHED [terrastories_e2e 4/9] RUN mkdir /gems                                                                                                                          0.0s
 => CACHED [terrastories_e2e 5/9] WORKDIR /gems                                                                                                                            0.0s
 => CACHED [terrastories_e2e 6/9] COPY Gemfile Gemfile.lock ./                                                                                                             0.0s
 => ERROR [terrastories_e2e 7/9] RUN bundle install                                                                                                                       15.5s
------
 > [terrastories_e2e 7/9] RUN bundle install:
#0 4.392 Fetching gem metadata from https://rubygems.org/..........
#0 15.16 Resolving dependencies...
#0 15.22 Fetching public_suffix 5.0.0
#0 15.37 Installing public_suffix 5.0.0
#0 15.38 Gem::RuntimeRequirementNotMetError: public_suffix requires Ruby version >= 2.6.
#0 15.38 The current ruby version is 2.5.0.
#0 15.38 An error occurred while installing public_suffix (5.0.0), and Bundler cannot
#0 15.38 continue.
#0 15.38 Make sure that `gem install public_suffix -v '5.0.0' --source
#0 15.38 'https://rubygems.org/'` succeeds before bundling.
#0 15.38
#0 15.38 In Gemfile:
#0 15.38   capybara-screenshot was resolved to 1.0.26, which depends on
#0 15.38     capybara was resolved to 3.37.1, which depends on
#0 15.38       addressable was resolved to 2.8.1, which depends on
#0 15.38         public_suffix
------
failed to solve: executor failed running [/bin/sh -c bundle install]: exit code: 5
➜  terrastories git:(master) ruby -v
ruby 2.6.8p205 (2021-07-07 revision 67951) [universal.arm64e-darwin21]
image
rudokemper commented 2 years ago

Hi @asheerrizvi sorry about that; I forgot to mention that the current main branch is out of date on dependency updates. Please try building this branch: https://github.com/Terrastories/terrastories/tree/administrate-refactor-part-1

asheerrizvi commented 2 years ago

@rudokemper cool will try it out!

asheerrizvi commented 2 years ago

Hey @rudokemper apologies for getting back late but getting this warning now:

image

docker is running but docker-compose build doesn't seem to be doing anything for me.

asheerrizvi commented 2 years ago

@rudokemper have opened a PR here:

https://github.com/Terrastories/terrastories/pull/813