search

TerriaJS / RaPPMap

Fork of TerriaJS/TerriaMap for GEOGLAM RAPP
6 stars 4 forks source link

Timeslider share time becomes end time for some shares #36

Closed a-stacey closed 7 years ago

a-stacey commented 7 years ago

I have tried to reproduce this against TerriaMap, but at the moment I am only able to reproduce against Geogalm, although I have suspicion that this is an issue in TerriaJS.

Here is a share that is effected by this issue: http://map.geo-rapp.org/#share=s-iFD9OwtbCx7rTmYQuvkpB6bMFYT

The following shows the instance loaded from the share link, with the end at the shared time but not screenshot from 2017-07-26 10-21-19

Steps to reproduce: 1) Load geoglam: http://map.geo-rapp.org 2) Turn in addition to the default layer "Total Vegitation Cover (PV + NPV)" turn on "CHIRPS Precipitation - Absolute" (Climate -> Rainfall -> CHIRPS Precipitation - Absolute). 3) Set a manual time on the time slider. 4) Create and load the share link. The instance loaded from the share link will end and the time shared.

I have tested with the two layers independently and it does not seem to cause this issue it seems only to be the case when both are loaded at the same time. I have loaded the two layers on a TerriaMap instance and it does not seem to have the same issue.

a-stacey commented 7 years ago

Don't know why I couldn't reproduce this locally last week (might have just been trying to be to quick since was working on another issue at the time) since I seem to be able to reproduce locally today. Have submitted a PR which fixes the issue with the local problem which will need to be merged and then once merged Geoglam will need to be deployed against this version to resolve the issue.

Will leave this issue open until it is confirmed as fixed in the production instance.

a-stacey commented 7 years ago

Have verified that this is now working correctly in the production instance.