TerriaJS / aremi-natmap

AREMI fork of the NICTA/nationalmap repo.
11 stars 13 forks source link

AREMI v2018-09-28 Pre-Release Test - Color scale range update feature #272

Closed EhsanCanberra closed 6 years ago

EhsanCanberra commented 6 years ago

The Color Scale Range Update by user feature is great! Users will definitely find it useful and love it.

Curiously, I have tested some values in the range input boxes - all worked fine.

However, you may have to add a 'range-boundary' check to validate before committing update. For example, as shown in Slide 4, the range of the data is 27.5 (max) and 9.5 (min). I have changed that to 1 (max) and 0 (min) -- both numbers are outside the above range -- and commit Update Range (Slide 5) Interestingly, it did accept that and then blacked out all the data (Slide 6). Is this expected? :)

Ps. Found the following tests that have been implemented: negative number (Slide 7), max<min (Slide 8)

slide4

slide5

slide6

slide7

slide8

AnaBelgun commented 6 years ago

This is probably a setting for the BoM server @meh9?

meh9 commented 6 years ago

As far as I know it's not possible to actually get the min/max values of the data ahead of time from ncWMS - you have to either get the default and read the legend to find min/max, or experiment yourself, so there is little we can do about this.