search

TerriaJS / aremi-natmap

AREMI fork of the NICTA/nationalmap repo.
11 stars 13 forks source link

NOM live test site issue: crashing chart #359

Open elangham opened 5 years ago

elangham commented 5 years ago

The (awesome!) test site created by @steve9164 currently has 2 issues that would be great to get resolved. This is Issue #2 of 2.

The test site has an error in the peak day chart when it is created with moustache template content identical to the current Peak Day Available Capacity map on the NOM production version (on AREMI). As soon as you click a polygon in the Peak Day Available Capacity map it crashes to a white screen, when using this gist version that exactly replicates the AREMI version of NOM: http://ci.terria.io/vt_custom_region_mapping/#clean&https://gist.githubusercontent.com/elangham/53d26f06aa1f7ce9f8ca937a13fd028b/raw/8ee6718dd0349e05569989ec9fc7a84afb67090b/nom-regions-multi.json

In Slack Stephen suggested 2 things “it’s either config related or the data shape from properties doesn’t match” and “There's a problem with the chart's {{terria.timeseries.yName}} templating. I'm not sure why it's happening yet, but that's where the error comes from”

To get it working for data supplier review we removed the chart part of the moustache template to get it to work (<chart x-column='{{terria.timeSeries.xName}}'\n y-column='{{terria.timeSeries.yName}}'\n id='{{terria.timeSeries.id}}'\n column-units='{{terria.timeSeries.units}}'>\n {{terria.timeSeries.data}}\n), in this version: http://ci.terria.io/vt_custom_region_mapping/#clean&https://gist.githubusercontent.com/elangham/5966c96a04f1a52a677e339a13a74717/raw/4c4b3090984ab1a940e3be74ba12a12777606876/nom-regions-review.json

However, with this not fully functional version you can still view a raw chart by clicking “View raw data” (blue button).

elangham commented 5 years ago

(note that this doesn’t have to be resolved for the early June NOM public release but we have another transmission version going live in late July so would be great if it works for that)