Feature info GA data - foreign (looking) language

[AnaBelgun]

When adding some web service (especially with polygon data), the feature info presents text in a foreign language. To investigate.

Examples (all GA services)

Polygons/ areas

• https://nationalmap.gov.au/#share=s-frNKoRRh4d0lijaDb3sanE8Nh5c

• https://nationalmap.gov.au/#share=s-wlWueJHjCumof52KHWv2XErQtqi

Points:

• https://nationalmap.gov.au/#share=s-knrfliTxf87qL5mjIkHh9eN66wR

[AnaBelgun]

Update 23 May 2022

Investigation & Fixes

Examples:

• Bad GetInfoRequest: https://nationalmap.gov.au/proxy/_0d/http://services.ga.gov.au/gis/services/BarestEarthSentinel2MapIndex/MapServer/WMSServer?exceptions=XML&version=1.3.0&feature_count=101&crs=EPSG%3A3857&styles=default&service=WMS&request=GetFeatureInfo&layers=BarestEarthSentinel2MapIndex&bbox=15028131.257091936%2C-3757032.814272985%2C16280475.528516259%2C-2504688.542848654&width=256&height=256&query_layers=BarestEarthSentinel2MapIndex&info_format=text%2Fhtml&i=226&j=59
• After changing GetInfoRequest to info_format=text/xml: https://nationalmap.gov.au/proxy/_0d/http://services.ga.gov.au/gis/services/BarestEarthSentinel2MapIndex/MapServer/WMSServer?exceptions=XML&version=1.3.0&feature_count=101&crs=EPSG%3A3857&styles=default&service=WMS&request=GetFeatureInfo&layers=BarestEarthSentinel2MapIndex&bbox=15028131.257091936%2C-3757032.814272985%2C16280475.528516259%2C-2504688.542848654&width=256&height=256&query_layers=BarestEarthSentinel2MapIndex&info_format=text%2Fxml&i=226&j=59
• this seems to fix it: http://ci.terria.io/main/#clean&%20https://gist.githubusercontent.com/nf-s/aff559b09813ac4f33745cbbff4f7eb5/raw/d3689bfdd48ef23b411d057b63c389c84f13f38b/esri-wms-info-format.json
• Adding the getFeatureInfoFormat trait value
• we changed how we select the GetFeatureInfo format; but it is to WMS spec; the issue seems to happen with some ArcGis server WMS endpoints
• We prioritise the format in the following order: 3:42

1. JSON
2. HTML
3. GML
4. Text

https://github.com/TerriaJS/terriajs//blob/4a1536f4a2068ce3041e3b08fd03ea193ae9e69d/lib/Models/Catalog/Ows/WebMapServiceCapabilitiesStratum.ts#L[…]9

It looks through WMS GetCapabilities to find first format which is supported

The GA ArcGis WMS services show they support text/html http://services.ga.gov.au/gis/services/BarestEarthSentinel2MapIndex/MapServer/WMSServer?version=1.3.0&request=GetCapabilities&service=WMS

• The default WMS version is 1.3.0
• It can be changed by setting version in the url or setting useWmsVersion130 = false
• tested some other ArcGis WMS services with text/html GetFeatureInfo requests and they work fine

[AnaBelgun]

Nick will check the ArcGIS WMS service for the WMS version

[nf-s]

I checked most esri WMS layers - couldn't find any others which needed WMS version or GetFeatureInfo format changed