TerriaJS / natmap-catalog-v8

Edit v8 nationalmap catalog
0 stars 1 forks source link

Update ga layers 2 #10

Closed mwu2018 closed 3 years ago

mwu2018 commented 3 years ago

Address issue https://github.com/TerriaJS/nationalmap/issues/986

https://tiles.terria.io/static/natmap-2021-02-10-v8.json is now used by https://nationalmap.dev.saas.terria.io The updated or newly added datasets can be viewed by:

@AnaBelgun I choose to add the new datasets to those groups. Please advise if the choices are OK.

mwu2018 commented 3 years ago

It's a convention in NationalMap in all groups to sort items by name. At the moment the groups are sorted in the statement about your code that adds new GA items. You should reorganise these statements so that the recursive sorting happens after your modifications.

Done.

mwu2018 commented 3 years ago

I will update existing json file in s3 bucket.

mwu2018 commented 3 years ago

All sorted now. See https://nationalmap.dev.saas.terria.io

nf-s commented 3 years ago

All looks good to me!

nf-s commented 3 years ago

Are you happy for me to merge this @steve9164 ?