search

TerriaJS / neii-viewer

Data viewer for National Environmental Information Infrastructure
http://neii.gov.au/viewer/
Apache License 2.0
8 stars 4 forks source link

SOS2 on staging: Water storage data missing #92

Open ChantelleDoan opened 7 years ago

ChantelleDoan commented 7 years ago

Hi @RacingTadpole, Could you assist to help look into the below issue that was rasied this week.

Issue: It seems the SOS2 call is not pulling all the Water Storage Levels and Water Storage Volume from the WISKI database. It is currently no showing data for NT, SA and WA. I have included a screen shots from both the Staging Viewer and WISKI for us to compare the data spread.

Note: The Water Course Level and Discharge are both showing data across Australia as expected.

staging water storgae wiski storage data

Thanks Arthur, Chantelle

RacingTadpole commented 7 years ago

Sure. The trick is that time slider at the bottom. At the date chosen (1/1/1980), there's no data from WA, NT or SA. If you move the slider to the right, you'll see them appear when they have data.

Alternatively, we could always show all the sites, but make them grey if there's no data.

ChantelleDoan commented 7 years ago

MISSING DATA INVESTIGATION: Thanks for the explanation Arthur. I understand better how it currently works. My understanding of how the map functions currently:

  1. A dot/site will appear on the map from the first observation date onwards, currently "Observation Date". Hence why no dots for WA, NT, SA.

  2. Once a dot is present on a map after the first obs date, then it will remain on the map from that date onwards. Hence why as you slide the time slider to the right, more and more site will appear with no sites deleted.

  3. A dot will appear grey if there is no data corresponding to the time slider selected date.

The above proved true for most of the sites but I came across a few sites they did not follow the above rules. For example, Bedford Weir HW. A dot appears grey for Bedford Weir HW when the time slider is in the default position of 1/1/1980. The site/dot only changes to colour if I move the time slider to 1/1/1996. I was expecting to not see a dot for Bedford Weir until after 1/1/1996? It would be great if you could look into this further.

http://staging.neiiviewer.nicta.com.au/#share=s-m0gAWFa6sLn3XaorBtzIfCBREaw

[cid:image003.jpg@01D2C4FD.5D91EC60]

REQUESTED CHANGES:

  1. Quite a number of people at BoM when reviewing the SOS2 data on the Viewer (including myself) overlooked the time slider at the bottom is default to 1/1/1980. So it would be good if you could change by default to show all the sites as you suggested and grey it out if there is no data. This would also resolve the odd cases like Bedford Weir HW?

  2. Also, in addition to the "Observation Date" on the Feature Info pop-up (reflecting the selected date on the time slider, ie if I move the time slider when the pop-up Feature Info is showing then the date will change as the slider position changes), it would be really helpful if we could also add "Latest Observation Date" to easily see the most recent data collected without having to use the time slider.

Thanks Arthur.

Regards, Chantelle Doan | NEII Programme Manager [Description: Description: cid:389443803@21082013-35A7] Environmental Information Services Bureau of Meteorology GPO Box 1289 Melbourne VIC 3001 Level 9, 700 Collins Street, Docklands VIC 3008 Tel: +61 3 9669 4475 | chantelle.doan@bom.gov.aumailto:chantelle.doan@bom.gov.au | www.bom.gov.auhttp://www.bom.gov.au/ [app email badge.jpg]http://www.bom.gov.au/app

From: Arthur Street [mailto:notifications@github.com] Sent: Thursday, 4 May 2017 4:13 PM To: TerriaJS/neii-viewer Cc: Chantelle Doan; Author Subject: Re: [TerriaJS/neii-viewer] SOS2 on staging: Water storage data missing (#92)

Sure. The trick is that time slider at the bottom. At the date chosen (1/1/1980), there's no data from WA, NT or SA. If you move the slider to the right, you'll see them appear when they have data.

Alternatively, we could always show all the sites, but make them grey if there's no data.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/TerriaJS/neii-viewer/issues/92#issuecomment-299103873, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ARD-l_UJHNyys-v-t3wJS1oJM-vX9qOQks5r2WxogaJpZM4NQMla.

RacingTadpole commented 7 years ago

I think the differences in grey dots arise because the server sometimes returns data from 1980 but with missing values from 1980-1986 (say), and other times the data just starts in 1986. But I agree it's confusing to the user, so I'll look into making it consistent.

Re the Latest Observation Date - do you want two new rows, "Latest Observation Date" and "Storage Level at Latest Observation Date", since the "Storage Level" is at the "Observation Date"?

image

That might be harder, since the Feature Info is really geared towards showing all the current data for a feature, and pulling in data from another date could be tricky to implement (especially if there are missing values at the end, so it needs to work backwards till it finds a valid value).

ChantelleDoan commented 7 years ago

Thanks Arthur, yes, adding 2 new rows for below would be great:

  1. Storage Level "Latest Observation Date" and "Storage Level at Latest Observation Date"

  2. Storage Volume "Latest Observation Date" and "Storage Volume at Latest Observation Date"

Regards, Chantelle Doan | NEII Programme Manager [Description: Description: cid:389443803@21082013-35A7] Environmental Information Services Bureau of Meteorology GPO Box 1289 Melbourne VIC 3001 Level 9, 700 Collins Street, Docklands VIC 3008 Tel: +61 3 9669 4475 | chantelle.doan@bom.gov.aumailto:chantelle.doan@bom.gov.au | www.bom.gov.auhttp://www.bom.gov.au/ [app email badge.jpg]http://www.bom.gov.au/app

From: Arthur Street [mailto:notifications@github.com] Sent: Friday, 5 May 2017 9:31 AM To: TerriaJS/neii-viewer Cc: Chantelle Doan; Author Subject: Re: [TerriaJS/neii-viewer] SOS2 on staging: Water storage data missing (#92)

I think the differences in grey dots arise because the server sometimes returns data from 1980 but with missing values from 1980-1986 (say), and other times the data just starts in 1986. But I agree it's confusing to the user, so I'll look into making it consistent.

Re the Latest Observation Date - do you want two new rows, "Latest Observation Date" and "Storage Level at Latest Observation Date", since the "Storage Level" is at the "Observation Date"?

[image]https://cloud.githubusercontent.com/assets/1757858/25728950/7a9679cc-3175-11e7-83e3-bb32fadae6b4.png

That might be harder, since the Feature Info is really geared towards showing all the current data for a feature, and pulling in data from another date could be tricky to implement (especially if there are missing values at the end, so it needs to work backwards till it finds a valid value).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/TerriaJS/neii-viewer/issues/92#issuecomment-299336932, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ARD-l_D7imJ0_irC79MrNJiqCPnxDx0nks5r2l-7gaJpZM4NQMla.