TerriaJS / terrarium

Showcase for Terria maps and features
Other
3 stars 6 forks source link

IDs in layers #3

Open rdengate opened 8 years ago

rdengate commented 8 years ago

For some maps, each layer has a hand-generated id, so that if the layer location changes the share link will still work. Some maps don't have this though, so I had to disable it for Terrarium.

Is there a better way we could manage this? As it seems kind of painful. If not, we will need to add ids to map data that doesn't have them, or risk the share feature not working.

On a related note, if there's a duplicate id bad things happen, like your ABC News Stories shows up labelled as BOM data. Possibly there's a duplicate id check in the check that makes sure all ids exist, but I disabled that, so it wasn't caught.