search

TerriaJS / terriajs

A library for building rich, web-based geospatial data platforms.
https://terria.io
Apache License 2.0
1.16k stars 361 forks source link

Disclaimer overlaps map credits in printed view in 2D / Chrome #1194

Closed kring closed 8 years ago

kring commented 8 years ago

image

chloeleichen commented 8 years ago

Which datasets should I turn on to reproduce this issue?

kring commented 8 years ago

You don't need to turn on any datasets. Just switch to 2D and print from the Chrome hamburger menu.

chloeleichen commented 8 years ago

screen shot 2016-01-12 at 8 56 20 pm What about this?

chloeleichen commented 8 years ago

With background colour: bg-color

Black text: black-text

kring commented 8 years ago

That looks great! Whatever you think on the colors. Does it still look OK in 3D too?

chloeleichen commented 8 years ago

@kring do we still need the smaller disclaimer on print? if so, should it come before or after the big one?

kring commented 8 years ago

No, we don't need it, but it might be hard to get rid of, particularly in 3D. So it's fine to show both if that makes it easier. It doesn't even matter if 2D and 3D are consistent as long as both show the long disclaimer. It doesn't matter which one comes first.

chloeleichen commented 8 years ago

Removed small disclaimer

2D:

2d

3D

3d
kring commented 8 years ago

Doh I should have mentioned one important thing. The "NationalMap must not be used for navigation or precise analysis" part is not important in the printed view (which is what I thought you meant by "short disclaimer"), but the other map credits (e.g. Bing, Image courtesy of NASA, Earthstar Geographics SIO, © 2015 Microsoft Corporation, © 2010 NAVTEQ) do need to show up. I'm guessing that makes it much harder...

chloeleichen commented 8 years ago

What about this:

2D:

2d

3D :

3d
kring commented 8 years ago

That looks fine to me!