search

TerriaJS / terriajs

A library for building rich, web-based geospatial data platforms.
https://terria.io
Apache License 2.0
1.17k stars 362 forks source link

Focus management #3548

Open soyarsauce opened 5 years ago

soyarsauce commented 5 years ago

Raised from https://github.com/TerriaJS/terriajs/pull/3547 we should review how viewState's topElement interacts w/ focus/blur across the UI

https://github.com/TerriaJS/terriajs/pull/3547

nf-s commented 4 years ago

I don't know if this is relevant to this - but can we also add customisation options for the purple focus outline in mobx:

body {
      *:focus {
        outline: 3px solid #C390F9;
      }
    }
soyarsauce commented 4 years ago

@nf-s it's already toggled through experimentalFeatures - at least if you mean "customisation" to turn it off or on? If you must use the current build then leave experimentalFeatures as off and then add your own focus style to body? 😄

soyarsauce commented 4 years ago

(short of that you can put a pr through to make it a separate flag/customisation option 🙂 )

nf-s commented 4 years ago

Oki doke, I'll add a PR at some point!