search

TerriaJS / terriajs

A library for building rich, web-based geospatial data platforms.
https://terria.io
Apache License 2.0
1.18k stars 362 forks source link

Mobx (Design): Location search UI for multiple `locationSearchProviders`s #4178

Closed soyarsauce closed 4 years ago

soyarsauce commented 4 years ago

With the new change of location search provided by: https://github.com/TerriaJS/nsw-digital-twin/issues/248 https://github.com/TerriaJS/terriajs/pull/4162

Some relevant info

if we have more than 5 results, in master you are able to expand the search results to see more. But not in the new design. How long should the search results get? Do we take 3?5? from each of the three categories

  • Locations
  • Official Place Names
  • Addresses

Meaning a location search result list possibly spanning 15 results?

@vicborgy has said he will get a design together to address this.

Maybe a quick way forward is an expanded search results "view" in some way to restore the lost functionality in master.

We've lost the following functionality from master:

image

Here's an example of our current search provider duplicated three times, in the absence of an implemented GazetteerSearchProviderViewModel && GnafSearchProviderViewModel in mobx:

image

@steve9164 do you have any other things to add?

soyarsauce commented 4 years ago

anyway, terriajs#4178 re: multiple search providers - 2.5 options. 1: @borgy thinks up something revolutionary 2: we just sploosh all search provider results together so that there's 15 results instead of 5 2.5: show ~6 results, do "show more results" and that expands the rest in line

vicborgy commented 4 years ago

@soyarsauce here are my designs for location search. Any issues let me know https://invis.io/H4XI8PTUVCA

AnaBelgun commented 4 years ago

assigned 2 more epics, because it's important for both: Delta v3 and Onboarding v3, but especially for delta

soyarsauce commented 4 years ago

@AnaBelgun which part of this is relevant for delta/onboarding? This ticket is the "UI support" for multiple providers (and is merged now), but we don't have one tracking the actual port of gazetteer & gnaf searches - if you want to track those I'll close this and raise separate ticket for that?

AnaBelgun commented 4 years ago

Thanks @soyarsauce I thought it would be important because this is one of the 1st actions a user / new user would do: search for his location of interest. We can disconnect from the epic or leave as is, especially if done. I understand it doesn't come from this last testing, therefore I'll disconnect from that epic for clarity :)

soyarsauce commented 4 years ago

Thanks @AnaBelgun - all UI is done for this, including support for multiple search providers. Mobx will need to port the actual support for gnaf+gazetteer - tracked in https://github.com/TerriaJS/terriajs/issues/4424