search

TerriaJS / terriajs

A library for building rich, web-based geospatial data platforms.
https://terria.io
Apache License 2.0
1.16k stars 361 forks source link

Stratum choice #4723

Open zoran995 opened 4 years ago

zoran995 commented 4 years ago

Are there more extensive any information around the decisions on CommonStrata choices and when to use which?

I am working on the implementation of more generalised data search (search in the data catalog) and the usage of CommonStrata.underride for all layer data obtained from capabilities seems little wrong to me. Currently, in wms and wfs there are isOpenInWorkbench and layer name on the same stratum level

nf-s commented 3 years ago

Yep totally agree, and we should add some JSDoc strings to the CommonStrata enum

zoran995 commented 3 years ago

I solved the search part by adding CommonStrata.search locally and updating some catalog items to use it, but something like CommonStrata.catalogItem is maybe better naming for it to store information about catalog item. If you want I can create a pull request with the change mentioned above?