TerriaJS / terriajs

A library for building rich, web-based geospatial data platforms.
https://terria.io
Apache License 2.0
1.19k stars 364 forks source link

Templated feature info popup not outputting templated values #6228

Closed meh9 closed 2 years ago

meh9 commented 2 years ago

There are problems on NatMap with templated feature info popups not correctly incorporating the raw values in the template output. This issue was identified by a user who took the time to contact us.

Using this share URL: https://nationalmap.gov.au/#share=s-4hOUMxGiSHgQjxqGBJuuM7b5SqN The layer is National -> Energy -> Electricity -> Network -> New -> Distribution -> Substations.

  1. Notice that it is using the field Indicative new generation connection capacity available (MW) by default to visualise the points on the map, and the points have different colours and sizes indicating that there are values for that field.
  2. Click any of the points.
  3. You will see that the Indicative new generation connection capacity available (MW) field is not showing any values.
  4. Click Show Raw Data.
  5. You will see that existing_new_connection_capacity actually has a value.

The value Indicative new generation connection capacity available (MW) is a remapping from the "raw" field existing_new_connection_capacity which can be found in the catalog (https://github.com/TerriaJS/saas-catalogs-public/blob/main/nationalmap/catalog/energy/prod.json):

                            {
                              "name": "existing_new_connection_capacity",
                              "title": "Indicative new generator connection capacity (MW)"
                            },

Please fix the feature info templating to correctly output values.

Screen Shot 2022-03-30 at 16 00 37
nf-s commented 2 years ago

Closed by https://github.com/TerriaJS/terriajs/pull/6441