This is useful for rendering the app before we fully finish loading all the workbench items from a share link.
What this PR does
Currently when loading a share URL with several items in the workbench, the app does not render until all workbench items have been loaded. If the data custodian server is slow, this could be perceived as Terria being slow to load. This PR contains changes for testing a different behaviour where we render the app before all workbench datasets have been loaded.
Some implications:
User can view and interact with the app before all datasets have been loaded. This creates more complexity as we need to be careful not to override the changes user might have made while the datasets were loading.
Data loading errors will be raised to the user later when we have finished all datasets - this could be surprising
User needs to be aware from various spinners in the workbench/feature info panel that the datasets haven't been fully loaded. Other UX changes might be required to make this more obvious.
Test me
How should reviewers test this? (Hint: If you want to provide a test catalog item, create a Gist of its catalog JSON, add its url and your branch name to this url: http://ci.terria.io/<branch name>/#clean&<raw url of your gist> , and then paste that in the body of this PR)
Checklist
[ ] There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
[ ] I've updated relevant documentation in doc/.
[ ] I've updated CHANGES.md with what I changed.
[ ] I've provided instructions in the PR description on how to test this PR.
This is useful for rendering the app before we fully finish loading all the workbench items from a share link.
What this PR does
Currently when loading a share URL with several items in the workbench, the app does not render until all workbench items have been loaded. If the data custodian server is slow, this could be perceived as Terria being slow to load. This PR contains changes for testing a different behaviour where we render the app before all workbench datasets have been loaded.
Some implications:
Test me
How should reviewers test this? (Hint: If you want to provide a test catalog item, create a Gist of its catalog JSON, add its url and your branch name to this url:
http://ci.terria.io/<branch name>/#clean&<raw url of your gist>
, and then paste that in the body of this PR)Checklist
doc/
.