Remove Carto basemaps. - Githubissues

TerriaJS / terriajs

A library for building rich, web-based geospatial data platforms.

https://terria.io

Apache License 2.0

1.19k stars 363 forks source link

Remove Carto basemaps. #7314

Closed na9da closed 5 days ago

na9da commented 1 week ago

What this PR does

Remove positron and darkmatter basemaps.

The Carto ones are no longer free and requires an Enterprise or Grantee license. If you have the appropriate license you can add them via your initialization file.

Here's the example configuration to add back Carto basemaps provided you have the necessary license.

Also removed the nasa-black-matter basemap which was decommissioned.

Test me

Open CI - http://ci.terria.io/remove-basemaps
Ensure the map settings does not list positron and darkmatter maps
Ensure the preview map doesn't show positron map

Note, this also requires a terriamap PR to update the default basemap settings in simple.json.

Checklist

[ ] There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
[ ] I've updated relevant documentation in doc/.
[x] I've updated CHANGES.md with what I changed.
[x] I've provided instructions in the PR description on how to test this PR.