search

TerrordactylDesigns / boombot

Node.js powered Chat and DJ bot for Turntable.fm
http://terrordactyldesigns.github.com/boombot/
MIT License
24 stars 18 forks source link

Queue drops all active users after a user is enforced #4

Closed TerrordactylDesigns closed 12 years ago

TerrordactylDesigns commented 12 years ago

Users being pulled off stage for not being their turn triggers the rem_dj event. Depending on the amount of times they try they will end up changing the value of the boolean that says to announce the next person or not. this causes the event to recurse and dump the queue.

technobly commented 11 years ago

So what was the resolution on this?

I pulled in your queue code from version 1.4.2. I see now that you've completely restructured the files. I really love one file as it makes it very simple to create new bots... and easy to just open and edit and understand the code. I've even pulled all of the config.json stuff into the main JS file so I just need one file for everything.

I've done some things like figure out who's on deck when the bot loads and start the queue with whoever is the current DJ. I run a 1 song and done queue, so they go down right after their song plays. Obviously I have to remove the dj's to the left of them as well for it to work properly... but I'll typically make bot edits and restart it when the #1 left most DJ just starts their song (so know one is the wiser).

TerrordactylDesigns commented 11 years ago

@DubbyTT this commit here should do the trick for you: https://github.com/TerrordactylDesigns/boombot/commit/98d87101d6f6e4fb99a1f587db765de27eecd03e

If you want the last version of the bot before I moved to V2 you can use the "Tags" link on the code page and download the last 1.4.x code before I did the overhaul.

technobly commented 11 years ago

Thanks Michael! Code is updated and running... looks like it should fix things, I'll report back after stress testing. xD