Based on Ethan's hunch, I simply removed the format comparison that decides whether to halt and restart, or reuse the voice. Voices are now always restarted when playing a new track.
This also simplifies the code somewhat: MusicTrack::musicVoiceFormat was now no longer used, and an if (!IsHalted()) was no longer necessary because Halt() already does that. So those are now removed as well.
Legal Stuff:
By submitting this pull request, I confirm that...
[x] My changes may be used in a future commercial release of VVVVVV
[x] I will be credited in a CONTRIBUTORS file and the "GitHub Friends"
section of the credits for all of said releases, but will NOT be compensated
for these changes
Changes:
Fixes #1057.
Based on Ethan's hunch, I simply removed the format comparison that decides whether to halt and restart, or reuse the voice. Voices are now always restarted when playing a new track.
This also simplifies the code somewhat:
MusicTrack::musicVoiceFormatwas now no longer used, and anif (!IsHalted())was no longer necessary becauseHalt()already does that. So those are now removed as well.Legal Stuff:
By submitting this pull request, I confirm that...
CONTRIBUTORSfile and the "GitHub Friends" section of the credits for all of said releases, but will NOT be compensated for these changes