TerryCavanagh / VVVVVV

The source code to VVVVVV! http://thelettervsixtim.es/
Other
6.93k stars 555 forks source link

Revert text image fading #1110

Closed mothbeanie closed 7 months ago

mothbeanie commented 7 months ago

Changes:

This reverts the following commits:

Recently, text images were changed to fade in with textboxes, where before they previously appeared after the fade. This created a charming effect where the images would appear to "load in" once the textbox finishes fading in. This behavior really complements the retro aesthetic the game is going for. Changing it to a fade is a needless change in direction, as it was not a bug in the first place and looked good already.

Additionally, custom levels have used text images (levelcomplete and gamecomplete) in creative ways by replacing them with something else to show as 'foreground' or as a cutscene image. Changing text images to fade has unintended consequences for levels that have utilized them in this fashion.

Current behavior, with fades (in English and Arabic):

https://github.com/TerryCavanagh/VVVVVV/assets/19874772/79d59cca-f2fe-4cca-9f0f-465ea3c1093b

https://github.com/TerryCavanagh/VVVVVV/assets/19874772/b6f55f57-73ed-4a12-896d-da575908db77

Without fades (behavior before today):

https://github.com/TerryCavanagh/VVVVVV/assets/19874772/0474803c-2a8a-49c1-98fb-a2b35aa5f7b1

https://github.com/TerryCavanagh/VVVVVV/assets/19874772/88344e25-9e43-4b87-89ea-47c881176c30

Legal Stuff:

By submitting this pull request, I confirm that...

InfoTeddy commented 7 months ago

We can disable fading if the graphics are customized.

mothbeanie commented 7 months ago

I mentioned that as an aside - I prefer the non fading behavior for all text images, customized or not. It looked good as it was