search

TerryCavanagh / VVVVVV

The source code to VVVVVV! http://thelettervsixtim.es/
Other
6.93k stars 555 forks source link

Add missing Viridian squeaks to cutscene test menu #1129

Open InfoTeddy opened 7 months ago

InfoTeddy commented 7 months ago

These mildly annoyed me. It should be consistent that whenever you press ACTION on a menu option, you get a Viridian squeak (at least if something happens).

Legal Stuff:

By submitting this pull request, I confirm that...

Daaaav commented 7 months ago

I don't agree - the squeaks are missing on purpose because if you have a lot of cutscenes to test, it could become annoying to hear all the squeaks. So this makes it easier to bear. Also, as a translator menu option, consistency should be less of a concern anyway.

flibitijibibo commented 7 months ago

It also makes me think of the earlier textbox change, and I wonder if we should start being more strict about userspace breakages - obviously we'll still have lots of editor changes but minimizing those changes for existing features may be a good idea at this point.

Daaaav commented 7 months ago

I don't mind userspace improvements by themselves, but people have to agree that they're improvements. :)

TerryCavanagh commented 7 months ago

I guess I'm very mildly with @InfoTeddy on this one, just because it's something I've noticed too. Consistency is probably good. But I usually have the game muted when I'm working on it, so I don't care that much! (sorry, this is not a useful comment)

flibitijibibo commented 7 months ago

I guess this would be the determining factor: If the localizers are okay with mashing the built-in mute key that would be enough to merge this, since people dealing with that screen frequently could ignore it if it becomes a problem. I'll +1/-1 whatever they decide in this case!

InfoTeddy commented 7 months ago

the squeaks are missing on purpose because if you have a lot of cutscenes to test, it could become annoying to hear all the squeaks.

I would just like to point out that the cutscenes themselves still have all the squeaks.

If the localizers are okay with mashing the built-in mute key that would be enough to merge this

Presumably, they are already doing this, since the cutscenes already contain squeaks.

Daaaav commented 7 months ago

I would just like to point out that the cutscenes themselves still have all the squeaks.

Yes, that's kind of my point - there are already so many squeaks in the cutscenes themselves that making every cutscene start with an additional squeak only adds to the pile of squeaks. And I feel you can probably get immersed in the cutscenes better if all squeaks you hear belong only to the cutscenes, and you can clearly hear when a textbox has appeared for you to read?

flibitijibibo commented 7 months ago

I guess to reiterate: Totally happy to let the localizers make the final call - if they say no, that's enough to block this change in favor of documenting the history of why this quirk exists.

Daaaav commented 7 months ago

Just gonna copy-paste this conversation here...

Discord convo part 1 Discord convo part 2

Update: Discord convo part 3

And for completeness, the comparison videos:

https://github.com/TerryCavanagh/VVVVVV/assets/44736680/0230af1c-0be2-43e2-a9a2-8312df1ad3c3

https://github.com/TerryCavanagh/VVVVVV/assets/44736680/ee06ff6c-42c5-4c84-9856-53617f445184

For what it's worth, I'm one of the localizers myself so my personal vote would be for no, but not because I remember what the experience was actually like. Maybe it doesn't matter that much, though.