Fix regression: Entities not moving - Githubissues

TerryCavanagh / VVVVVV

The source code to VVVVVV! http://thelettervsixtim.es/

Other

6.9k stars 553 forks source link

Fix regression: Entities not moving #1177

Closed InfoTeddy closed 1 month ago

InfoTeddy commented 1 month ago

Commit 53d725f78a3550b750d652a62ffe9d8b51dd0e18, intended to fix an overzealous commit, was itself overzealous. This is because it applied to all entities when it should only apply to entity-emitting entities. To fix this, entityclonefix needs to no-op if the entity is not an entity emitter.

Fixes #1176.

Legal Stuff:

By submitting this pull request, I confirm that...

[x] My changes may be used in a future commercial release of VVVVVV
[x] I will be credited in a CONTRIBUTORS file and the "GitHub Friends" section of the credits for all of said releases, but will NOT be compensated for these changes unless there is a prior written agreement

Daaaav commented 1 month ago

From some playtesting in the main game and custom levels, this seems to be a non-overzealous fix.