/EHsc does not actually disable exceptions on MSVC, it only makes the compiler assume that extern "C" functions never throw C++ exceptions.
We had a discussion on Discord about actually disabling exceptions, and from research, that requires defining _HAS_EXCEPTIONS=0, but it's unsupported and undocumented so we deemed the benefits not worth it. Thus, we will stay with /EHsc. But the comment still has to be updated.
[skip ci]
Legal Stuff:
By submitting this pull request, I confirm that...
[x] My changes may be used in a future commercial release of VVVVVV
[x] I will be credited in a CONTRIBUTORS file and the "GitHub Friends"
section of the credits for all of said releases, but will NOT be compensated
for these changes unless there is a prior written agreement
/EHsc
does not actually disable exceptions on MSVC, it only makes the compiler assume thatextern "C"
functions never throw C++ exceptions.We had a discussion on Discord about actually disabling exceptions, and from research, that requires defining
_HAS_EXCEPTIONS=0
, but it's unsupported and undocumented so we deemed the benefits not worth it. Thus, we will stay with/EHsc
. But the comment still has to be updated.[skip ci]
Legal Stuff:
By submitting this pull request, I confirm that...
CONTRIBUTORS
file and the "GitHub Friends" section of the credits for all of said releases, but will NOT be compensated for these changes unless there is a prior written agreement