TerryCavanagh / VVVVVV

The source code to VVVVVV! http://thelettervsixtim.es/
Other
6.9k stars 553 forks source link

Fix wrong comment on disabling MSVC exceptions #1181

Closed InfoTeddy closed 4 days ago

InfoTeddy commented 2 weeks ago

/EHsc does not actually disable exceptions on MSVC, it only makes the compiler assume that extern "C" functions never throw C++ exceptions.

We had a discussion on Discord about actually disabling exceptions, and from research, that requires defining _HAS_EXCEPTIONS=0, but it's unsupported and undocumented so we deemed the benefits not worth it. Thus, we will stay with /EHsc. But the comment still has to be updated.

[skip ci]

Legal Stuff:

By submitting this pull request, I confirm that...