TerryCavanagh / VVVVVV

The source code to VVVVVV! http://thelettervsixtim.es/
Other
7k stars 559 forks source link

Use variable timestep for `SDL_Delay` #1186

Closed InfoTeddy closed 3 months ago

InfoTeddy commented 3 months ago

This fixes a bug where fast-forward wouldn't work in 30-FPS-only mode.

This is because the 30-FPS-only code has a hardcoded check for the number 34, as in 34 milliseconds must pass before the next frame can advance. This is why slowdown still worked, because slowdown means you're waiting longer than 34 ms anyways, but fast-forward tries to wait for only 1 ms, which wouldn't work if the 34 limit was still enforced.

So instead, swap out the 34 with game.get_timestep() and this will be fixed.

Fixes #1185.

Legal Stuff:

By submitting this pull request, I confirm that...

NyakoFox commented 3 months ago

lgtm