Update VS2019 to VS2022

TerryCavanagh / VVVVVV

The source code to VVVVVV! http://thelettervsixtim.es/

Other

7k stars 559 forks source link

Update VS2019 to VS2022 #864

Closed N00byKing closed 2 years ago

N00byKing commented 2 years ago

Required for Actions workflow due to windows-latest Version Change (Alternatively, pin Windows to 2019)

Changes:

I was having build issues on my fork, turns out the Github Actions windows-latest version change breaks the CMake Generator used atm. Update it to keep compatibility with windows-latest.

Legal Stuff:

By submitting this pull request, I confirm that...

[x] My changes may be used in a future commercial release of VVVVVV
[x] I will be credited in a CONTRIBUTORS file and the "GitHub Friends" section of the credits for all of said releases, but will NOT be compensated for these changes

InfoTeddy commented 2 years ago

The CI workflow for this PR failed.

2022-02-14_11-38-21

N00byKing commented 2 years ago

Seems like the change to the environments are coming in stages. For example, the Job Summary for this PR has the following warning: windows-latest workflows will use windows-2022 soon

Whereas the workflows on my repo have this one: windows-latest workflows now use windows-2022

InfoTeddy commented 2 years ago

Okay, that's a bit annoying then... Just change the runner to windows-2022 as well, then if it works I'll merge.

N00byKing commented 2 years ago

Added the change; workflows for PRs in this repo wont start without approval though

InfoTeddy commented 2 years ago

Almost forgot, you'll need to add yourself to CONTRIBUTORS.txt and githubfriends in Credits.h too. Do that and I'll start the workflow...

flibitijibibo commented 2 years ago

Looks like it is indeed rolling out slowly... let's stick with latest but wait until they've finished deploying.

N00byKing commented 2 years ago

Should I change it back to windows-latest then? Sidenote, would a PR to make cmake compile out of source be accepted? E.g. at the moment it generates in desktop_version, can this be changed to desktop_version/build for example?

InfoTeddy commented 2 years ago

Sidenote, would a PR to make cmake compile out of source be accepted? E.g. at the moment it generates in desktop_version, can this be changed to desktop_version/build for example?

You can already mkdir build, cd build, cmake ... What's the problem?

N00byKing commented 2 years ago

I meant in the workflow as well. Probably a low chance, but it would help me a bit as a submodule I use refuses in tree builds

InfoTeddy commented 2 years ago

Ah, so you want the Windows CI to do it as well. Yeah, that'd be acceptable.

InfoTeddy commented 2 years ago

let's stick with latest but wait until they've finished deploying.

I kind of don't want our CI to suddenly break since we don't know when it'll finish deploying, but I'll let you overrule me here.

N00byKing commented 2 years ago

Ah, so you want the Windows CI to do it as well. Yeah, that'd be acceptable.

Thats great to hear! CI is quite the headache, so deviating just a little less than before from upstream is a win to me Opened #865 for this.

N00byKing commented 2 years ago

I've dropped the contributor add commit and the change from windows-latest to windows-2022 pending Github deciding to switch this repo to 2022 for windows-latest

N00byKing commented 2 years ago

All Repos are now using windows-2022 as windows-latest

flibitijibibo commented 2 years ago

Really wish we could just re-test without updates...

Can you force-push one more time just to trigger CI? Once it passes I'll merge this in.

InfoTeddy commented 2 years ago

There is a "Re-run all jobs" button. I clicked it.