Closed N00byKing closed 2 years ago
The CI workflow for this PR failed.
Seems like the change to the environments are coming in stages.
For example, the Job Summary for this PR has the following warning:
windows-latest workflows will use windows-2022 soon
Whereas the workflows on my repo have this one:
windows-latest workflows now use windows-2022
Okay, that's a bit annoying then... Just change the runner to windows-2022
as well, then if it works I'll merge.
Added the change; workflows for PRs in this repo wont start without approval though
Almost forgot, you'll need to add yourself to CONTRIBUTORS.txt
and githubfriends
in Credits.h
too. Do that and I'll start the workflow...
Looks like it is indeed rolling out slowly... let's stick with latest
but wait until they've finished deploying.
Should I change it back to windows-latest
then?
Sidenote, would a PR to make cmake compile out of source be accepted? E.g. at the moment it generates in desktop_version
, can this be changed to desktop_version/build
for example?
Sidenote, would a PR to make cmake compile out of source be accepted? E.g. at the moment it generates in
desktop_version
, can this be changed todesktop_version/build
for example?
You can already mkdir build
, cd build
, cmake ..
. What's the problem?
I meant in the workflow as well. Probably a low chance, but it would help me a bit as a submodule I use refuses in tree builds
Ah, so you want the Windows CI to do it as well. Yeah, that'd be acceptable.
let's stick with
latest
but wait until they've finished deploying.
I kind of don't want our CI to suddenly break since we don't know when it'll finish deploying, but I'll let you overrule me here.
Ah, so you want the Windows CI to do it as well. Yeah, that'd be acceptable.
Thats great to hear! CI is quite the headache, so deviating just a little less than before from upstream is a win to me Opened #865 for this.
I've dropped the contributor add commit and the change from windows-latest
to windows-2022
pending Github deciding to switch this repo to 2022 for windows-latest
Really wish we could just re-test without updates...
Can you force-push one more time just to trigger CI? Once it passes I'll merge this in.
There is a "Re-run all jobs" button. I clicked it.
Required for Actions workflow due to windows-latest Version Change (Alternatively, pin Windows to 2019)
Changes:
I was having build issues on my fork, turns out the Github Actions windows-latest version change breaks the CMake Generator used atm. Update it to keep compatibility with windows-latest.
Legal Stuff:
By submitting this pull request, I confirm that...
CONTRIBUTORS
file and the "GitHub Friends" section of the credits for all of said releases, but will NOT be compensated for these changes