TerryCavanagh / diceydungeons.com

Dicey Dungeons
50 stars 7 forks source link

Some Reunion equipment becomes unusable when weakened #2828

Closed Ereza closed 2 years ago

Ereza commented 2 years ago

I will try to illustrate this with a sequence of images.

I was fighting with the Robot against Audrey and she inflicted 1 weaken. "Bailout" ("Rescat financer") was weakened and "has no effect", which is correct, but... has no coins shown and is unusable?

bailout_weakened_1

On the next turn, she inflicted 2 weaken. The weakened equipment was "Bear claws" ("Urpes d'ós") and "Market crash" ("Fallida borsària"). However, "Bailout" is now in normal status and has an effect, but... has no coins shown and does not accept any type of coin. "Bear claws" has mysteriously lost its coin indicator too, and is unusable.

bailout_weakened_2

On the next turn, she inflicted 3 weaken. The weakened equipment was "Bear claws", "Bailout" and "Cold hard cash" ("Diners frescos"). Now all of these three cards won't accept any coin.

bailout_weakened_3

On the next turn, she inflicted 1 weaken. The weakened equipment was "Bailout", but all three previously weakened items lost their coins indicator and did not accept any coin.

bailout_weakened_4

However, I must say that this does not always happen. I reproduced it in another play session, but in that case only "Bailout" exhibited this behavior, and "Bear claws" was weakened but correctly retained the coins indicator and correctly accepted coins. See this image:

coinds_not_always_disappear

Tested on v1.12.4 (reunion translator mode), 25-04-2022

ncrecc commented 2 years ago

this may have to do with when the weakened form of the combination equipment has more slots than the form it was weakened from

TerryCavanagh commented 2 years ago

Yeah, hmm - I thought this one was going to be fixable with a few spreadsheet tweaks - things like downgrades having different slot configurations - but it looks like it's a bit more serious than that. I'll just have to dig in and make sure combination slots work correctly with weaken.

TerryCavanagh commented 2 years ago

Fixed! The weirdness here is that this bug only happened if you had never used the item that was weakened. Once you applied a dice or coin, it fixed the required fields. Anyway, this is fixed now!