search

TerryZ / v-dialogs

A simple style useful dialog component collection for Vue
https://terryz.github.io/docs-vue3/dialog/
MIT License
130 stars 27 forks source link

some idea #7

Closed RezaErfani67 closed 5 years ago

RezaErfani67 commented 5 years ago

i hope to add responsive feature in next version...

second idea related to {params}... with this version of v-dialogs, we should change props name from {firstname} to {params.firstname} that is not good... it is better that i can send dynamic props name to child component...

RezaErfani67 commented 5 years ago

resolved it with this code:

<style>
@media only screen and (max-width: 479px){
  .v-dialog-dialog {
    width: 90% !important;
  }
}
</style>
TerryZ commented 5 years ago
  1. For params, very nice suggestion
  2. Did you use v-dialogs on the mobile side?
RezaErfani67 commented 5 years ago

not yet... but usually SPA Applications should work on desktop,surface,tablet and mobile

RezaErfani67 commented 5 years ago

in the modal.vue i change the code from

<component :is="component"   params="params"    @close="modalClose">             </component>

to

<component :is="component"   v-bind="params"    @close="modalClose">             </component>

and work good...

i close this and waiting for new version... thanks a lot... good luck

TerryZ commented 5 years ago

Make the props name dynamic just like what you did