TeselaGen / openVectorEditor

DEPRECATED - Teselagen's Open Source Vector/Plasmid Editor Component
https://teselagen.github.io/tg-oss/ove/#/Editor
MIT License
200 stars 72 forks source link

Added "and" logic to cutsite filtering #863

Closed djriffle closed 1 year ago

djriffle commented 1 year ago

connects https://github.com/TeselaGen/microbyre-support/issues/3

codecov-commenter commented 1 year ago

Codecov Report

Merging #863 (b2a1fc2) into master (fc07ed8) will increase coverage by 0.23%. The diff coverage is 86.20%.

@@            Coverage Diff             @@
##           master     #863      +/-   ##
==========================================
+ Coverage   74.80%   75.04%   +0.23%     
==========================================
  Files         289      290       +1     
  Lines       11116    11162      +46     
  Branches     3997     4013      +16     
==========================================
+ Hits         8315     8376      +61     
+ Misses       2460     2445      -15     
  Partials      341      341              
Impacted Files Coverage Δ
src/redux/restrictionEnzymes.js 60.00% <50.00%> (-2.50%) :arrow_down:
...erComponents/PropertiesDialog/CutsiteProperties.js 81.48% <60.00%> (-4.89%) :arrow_down:
src/CutsiteFilter/index.js 90.09% <85.93%> (+4.23%) :arrow_up:
src/withEditorProps/index.js 78.99% <89.47%> (+0.05%) :arrow_up:
src/selectors/filteredCutsitesSelector.js 86.66% <91.66%> (+4.31%) :arrow_up:
src/helperComponents/EnzymesDialog/index.js 80.41% <100.00%> (+0.10%) :arrow_up:
src/selectors/isEnzymeFilterAndSelector.js 100.00% <100.00%> (ø)
src/RowView/index.js 90.13% <0.00%> (-0.90%) :arrow_down:
demo/src/EditorDemo/index.js 86.03% <0.00%> (+0.63%) :arrow_up:
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

cypress[bot] commented 1 year ago



Test summary

256 7 1 0


Run details

Project openVectorEditor
Status Failed
Commit 28b3500dbe
Started Nov 22, 2022 6:40 AM
Ended Nov 22, 2022 7:10 AM
Duration 30:42 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Dashboard ➡️


Failures

editor.spec.js Failed
1 editor > should handle very long external labels in RowView
autoAnnotate.spec.js Failed
1 autoAnnotate > the auto annotation addon custom list should work
2 autoAnnotate > auto annotating parts should work when the csv file has a 'type' column
3 autoAnnotate > auto annotating parts should work when the csv file doesn't have a 'type' column
4 autoAnnotate > the auto annotation csv upload addon should work
virtualDigest.spec.js Failed
1 virtualDigest > clicking a fragment in the Digest Table view and then right clicking the selection to create a feature should have the annotation name autofilled
onSavePng.spec.js Failed
1 onSavePng > generate a png onSave if pngGenerate option is set to true

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] commented 1 year ago



Test summary

251 6 1 0


Run details

Project openVectorEditor
Status Failed
Commit b637990045 ℹ️
Started Nov 18, 2022 8:45 PM
Ended Nov 18, 2022 9:11 PM
Duration 25:20 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Dashboard ➡️


Failures

editor.spec.js Failed
1 editor > should handle very long external labels in RowView
autoAnnotate.spec.js Failed
1 autoAnnotate > the auto annotation addon custom list should work
2 autoAnnotate > auto annotating parts should work when the csv file has a 'type' column
3 autoAnnotate > auto annotating parts should work when the csv file doesn't have a 'type' column
4 autoAnnotate > the auto annotation csv upload addon should work
enzymeManager.spec.js Failed
1 enzymeManager > enzymes not shown by default should show up when added to a group (and hiding an enzyme that is shown in a group should work)

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

tnrich commented 1 year ago

@djriffle the tests you added look good. I've merged this branch into master and will look into any test breaks that might crop up. Good work!