Closed smeng9 closed 1 year ago
Merging #864 (747c596) into master (2e6a311) will increase coverage by
0.27%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #864 +/- ##
==========================================
+ Coverage 74.67% 74.94% +0.27%
==========================================
Files 271 289 +18
Lines 10672 11116 +444
Branches 3813 3997 +184
==========================================
+ Hits 7969 8331 +362
- Misses 2367 2444 +77
- Partials 336 341 +5
Impacted Files | Coverage Δ | |
---|---|---|
demo/src/VersionSwitcher.js | 28.57% <0.00%> (-60.32%) |
:arrow_down: |
src/SimpleCircularOrLinearView.js | 71.62% <0.00%> (-24.04%) |
:arrow_down: |
addons/AutoAnnotate/src/fileUtils.js | 37.50% <0.00%> (-12.50%) |
:arrow_down: |
demo/src/utils/renderToggle.js | 84.61% <0.00%> (-8.49%) |
:arrow_down: |
addons/AutoAnnotate/src/index.js | 66.44% <0.00%> (-7.87%) |
:arrow_down: |
src/CutsiteFilter/index.js | 85.85% <0.00%> (-5.36%) |
:arrow_down: |
...rc/RowItem/StackedAnnotations/PointedAnnotation.js | 92.43% <0.00%> (-4.00%) |
:arrow_down: |
src/CircularView/RotateCircularViewSlider.js | 86.36% <0.00%> (-2.53%) |
:arrow_down: |
src/selectors/filteredCutsitesSelector.js | 82.35% <0.00%> (-1.97%) |
:arrow_down: |
src/RowView/estimateRowHeight.js | 88.73% <0.00%> (-1.13%) |
:arrow_down: |
... and 73 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@smeng9 publishing this in v18.1.48 now! Lemme know if that does it for ya!
Also, could you link to where you're bundling OVE using vite? (if it's a public repo that is)!
Thanks, Thomas
I can publish a tutorial to use vite.
It provides so much speed up
@smeng9 please let me know when you publish that tutorial and include a link to it. Thanks!
Hi @tnrich https://stackblitz.com/edit/vitejs-vite-tglega?file=package.json&terminal=dev Its based off https://github.com/tnrich/ove-react-demo-repo
Needs to modify vite.config.js a little bit to make it work. If https://github.com/GMOD/gff-js/pull/58 and https://github.com/nodejs/readable-stream/pull/499 are resolved we no longer need to apply workaround on vite.config.js
Thanks for posting this @smeng9 ! I'm definitely interested in trying out using vite as the default bundler for developing OVE
Fix following warning during vite build