TeselaGen / openVectorEditor

DEPRECATED - Teselagen's Open Source Vector/Plasmid Editor Component
https://teselagen.github.io/tg-oss/ove/#/Editor
MIT License
199 stars 71 forks source link

Upgrade react redux #866

Closed XingGao-PKI closed 1 year ago

XingGao-PKI commented 1 year ago

Hi @tnrich,

I don't know if you plan to upgrade react or redux recently. But we are seeing some issues with different versions of react-redux. So creating this PR to upgrade react-redux here. My team member has reported this issue here (https://github.com/TeselaGen/openVectorEditor/issues/861) According to description in react-redux repo, upgrade this npm package should working fine with React 17 here.

image
codecov-commenter commented 1 year ago

Codecov Report

Merging #866 (cfa387b) into master (953aaed) will increase coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #866      +/-   ##
==========================================
+ Coverage   75.31%   75.33%   +0.01%     
==========================================
  Files         290      290              
  Lines       11170    11170              
  Branches     4027     4027              
==========================================
+ Hits         8413     8415       +2     
+ Misses       2421     2419       -2     
  Partials      336      336              
Impacted Files Coverage Δ
src/RowView/index.js 91.03% <0.00%> (+0.89%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

cypress[bot] commented 1 year ago



Test summary

262 1 1 0


Run details

Project openVectorEditor
Status Failed
Commit a95fd5709a ℹ️
Started Dec 13, 2022 6:29 AM
Ended Dec 13, 2022 6:59 AM
Duration 30:21 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Dashboard ➡️


Failures

cypress/e2e/chromatogram.spec.js Failed
1 chromatogram > the chromatogram visibility toggle shouldn't show up unless chromatogramData is present

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

tnrich commented 1 year ago

Hey @XingGao-PKI

This change will land in OVE v18.1.61

XingGao-PKI commented 1 year ago

Thanks @tnrich