TeselaGen / openVectorEditor

DEPRECATED - Teselagen's Open Source Vector/Plasmid Editor Component
https://teselagen.github.io/tg-oss/ove/#/Editor
MIT License
199 stars 71 forks source link

Fix tickSpacing not working issue #868

Closed XingGao-PKI closed 1 year ago

cypress[bot] commented 1 year ago



Test summary

263 0 1 0


Run details

Project openVectorEditor
Status Passed
Commit bcfb9bdc61
Started Dec 15, 2022 8:49 AM
Ended Dec 15, 2022 9:19 AM
Duration 30:39 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] commented 1 year ago



Test summary

258 5 1 0


Run details

Project openVectorEditor
Status Failed
Commit f914305d0b ℹ️
Started Dec 15, 2022 8:53 AM
Ended Dec 15, 2022 9:24 AM
Duration 30:18 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Dashboard ➡️


Failures

editor.spec.js Failed
1 editor > should handle clickOverrides correctly if they are passed
proteinEditor.spec.js Failed
1 proteinEditor > feature/part add/edit should be AA indexed
dialogs.spec.js Failed
1 dialogs > part dialog should -handle changing strand direction -todo handle notes add
chromatogram.spec.js Failed
1 chromatogram > the chromatogram visibility toggle shouldn't show up unless chromatogramData is present
onSavePng.spec.js Failed
1 onSavePng > generate a png onSave if pngGenerate option is set to true

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

codecov-commenter commented 1 year ago

Codecov Report

Merging #868 (bcfb9bd) into master (585f1bb) will decrease coverage by 0.11%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #868      +/-   ##
==========================================
- Coverage   75.31%   75.19%   -0.12%     
==========================================
  Files         290      290              
  Lines       11159    11176      +17     
  Branches     4022     4030       +8     
==========================================
  Hits         8404     8404              
- Misses       2419     2435      +16     
- Partials      336      337       +1     
Impacted Files Coverage Δ
src/LinearView/index.js 84.17% <100.00%> (+0.11%) :arrow_up:
src/MenuBar/index.js 65.38% <0.00%> (-26.93%) :arrow_down:
demo/src/EditorDemo/index.js 83.49% <0.00%> (-2.54%) :arrow_down:
src/RowView/index.js 90.26% <0.00%> (-0.77%) :arrow_down:
src/AlignmentView/index.js 73.33% <0.00%> (-0.05%) :arrow_down:
src/RowItem/index.js 77.65% <0.00%> (ø)
src/MenuBar/viewSubmenu.js 100.00% <0.00%> (ø)
src/redux/annotationVisibility.js 80.00% <0.00%> (ø)
src/utils/useChromatogramPrefs.js 100.00% <0.00%> (ø)
src/AlignmentView/updateTrackHelper.js 40.00% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

tnrich commented 1 year ago

@XingGao-PKI thanks for this! Good catch!

tnrich commented 1 year ago

Will land in v18.1.62 which is publishing now