Mobx refactor - Githubissues

codecov-commenter commented 1 year ago

Codecov Report

Merging #883 (fa422ee) into master (ff7e59d) will decrease coverage by 39.68%. The diff coverage is 42.36%.

:exclamation: Current head fa422ee differs from pull request most recent head 539706d. Consider uploading reports for the commit 539706d to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           master     #883       +/-   ##
===========================================
- Coverage   74.75%   35.07%   -39.68%     
===========================================
  Files         289      223       -66     
  Lines       11226    10275      -951     
  Branches     4062     3615      -447     
===========================================
- Hits         8392     3604     -4788     
- Misses       2483     5751     +3268     
- Partials      351      920      +569

Impacted Files	Coverage Δ
addons/AutoAnnotate/src/CreateAnnotationsPage.js	`10.71% <0.00%> (-89.29%)`	:arrow_down:
addons/AutoAnnotate/src/index.js	`6.04% <ø> (-68.46%)`	:arrow_down:
...mo/src/EditorDemo/AddEditFeatureOverrideExample.js	`0.00% <ø> (-35.64%)`	:arrow_down:
demo/src/MobXEditorDemo.js	`0.00% <0.00%> (ø)`
demo/src/SimpleCircularOrLinearViewDemo.js	`55.26% <ø> (-37.05%)`	:arrow_down:
demo/src/StandaloneDemo.js	`1.42% <ø> (ø)`
demo/src/index.js	`60.78% <0.00%> (+10.78%)`	:arrow_up:
demo/src/store.js	`75.00% <ø> (ø)`
src/AlignmentView/AlignmentVisibilityTool.js	`0.00% <0.00%> (-86.37%)`	:arrow_down:
src/CircularView/Axis.js	`90.00% <ø> (ø)`
... and 102 more

... and 67 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

cypress[bot] commented 1 year ago

243 failed tests on run #1597 ↗︎

243

15

1

12

0

Details:

tiny
Project: openVectorEditor	Commit: `8ce49c4aaf`
Status: Failed	Duration: 11:39 💡
Started: Mar 21, 2023 6:02 PM	Ended: Mar 21, 2023 6:14 PM

editor.spec.js • 33 failed tests

View Output Video

Test		Artifacts
editor > annotation limits should persist across reloads and be configurable from the menu		`Output` `Screenshots` `Video`
editor > annotation limits should not show up as options if maxAnnotationsToDisplay is passed		`Output` `Screenshots` `Video`
editor > should be able to hide the rotate circular view!		`Output` `Screenshots` `Video`
editor > should be able to hide the zoom circular view!		`Output` `Screenshots` `Video`
editor > should be able to hide the single import button if necessary!		`Output` `Screenshots` `Video`
editor > should be able to set visibilities!		`Output` `Screenshots` `Video`
editor > should fire the rename handler		`Output` `Screenshots` `Video`
editor > should fire the onSelectionOrCaretChanged handler		`Output` `Screenshots` `Video`
editor > should allow you to view, but not edit features/parts/primers when in read only mode		`Output` `Screenshots` `Video`
editor > you should not be able to change editability of a sequence when disableSetReadOnly=true		`Output` `Screenshots` `Video`
The first 10 failed tests are shown, see all 33 tests in Cypress Cloud.

menuBar.spec.js • 21 failed tests

View Output Video

Test		Artifacts
menuBar > fivePrimeThreePrimeHints should be toggleable		`Output` `Screenshots` `Video`
menuBar > Should be able to hide individual features		`Output` `Screenshots` `Video`
menuBar > Should be able to hide individual parts		`Output` `Screenshots` `Video`
menuBar > Should be able to filter features by length		`Output` `Screenshots` `Video`
menuBar > Should be able to filter part by length		`Output` `Screenshots` `Video`
menuBar > Should be able to change circular/linear from the menu bar		`Output` `Screenshots` `Video`
menuBar > should be able to use the search/shortcut bar to translate the sequence		`Output` `Screenshots` `Video`
menuBar > should be able to change the amino acid color (by hydrophobicity or by family)		`Output` `Screenshots` `Video`
menuBar > should be able to permanently change sequence case		`Output` `Screenshots` `Video`
menuBar > should be able to permanently change selected sequence case		`Output` `Screenshots` `Video`
The first 10 failed tests are shown, see all 21 tests in Cypress Cloud.

findTool.spec.js • 10 failed tests

View Output Video

Test		Artifacts
find tool > the find tool shouldn't get stuck in a weird state where the match number is greater than the number of matches		`Output` `Screenshots` `Video`
find tool > when there is only 1 search result, typing enter in the find tool should jump you back to the search layer		`Output` `Screenshots` `Video`
find tool > when there is only 2 search results but the search is palindromic, typing enter in the find tool should jump you back to the search layer		`Output` `Screenshots` `Video`
find tool > can be expanded and should have full functionality as such		`Output` `Screenshots` `Video`
find tool > find parts/primers/features		`Output` `Screenshots` `Video`
find tool > have clickable find layers		`Output` `Screenshots` `Video`
find tool > reverse strand matches should cause annotations created from right click to be in reverse direction		`Output` `Screenshots` `Video`
find tool > reverse strand matches should cause annotations created from click and then subsequent create to be in reverse direction		`Output` `Screenshots` `Video`
find tool > clear search layers when closed and retain the previous search and be selected when re-opened		`Output` `Screenshots` `Video`
find tool > -it starts with nothing selected -it can find dna letters -it can toggle the find options and highlight all -and toggle finding Amino acids		`Output` `Screenshots` `Video`

editing.spec.js • 9 failed tests

View Output Video

Test		Artifacts
editing > editing a part/feature and saving shouldn't make the new part/feature window initialize in edit mode		`Output` `Screenshots` `Video`
editing > should return focus correctly after typing in chars in circular view		`Output` `Screenshots` `Video`
editing > should return focus correctly after typing in chars in row view		`Output` `Screenshots` `Video`
editing > should be able to delete data around the origin correctly - the cursor should be placed at the origin		`Output` `Screenshots` `Video`
editing > should be able to insert data around the origin correctly - new sequence should be inserted after the origin		`Output` `Screenshots` `Video`
editing > should be able to revComp, comp selections that wrap the origin correctly - new sequence should be inserted after the origin		`Output` `Screenshots` `Video`
editing > should be able to change the color of features by changing the feature type		`Output` `Screenshots` `Video`
editing > should be able to edit a feature/part via double clicking		`Output` `Screenshots` `Video`
editing > should be able to edit a feature/part start/end by clicking/dragging in the editor		`Output` `Screenshots` `Video`

properties.spec.js • 9 failed tests

View Output Video

Test		Artifacts
properties > creating a primer should create a primer in the genbank at the selected range		`Output` `Screenshots` `Video`
properties > should be able to delete a feature from the properties tab and not have the delete button still enabled; - have the number of features correctly displayed -not be able to create a new feature if sequenceLength === 0		`Output` `Screenshots` `Video`
properties > a custom properties tab should be able to be added		`Output` `Screenshots` `Video`
properties > can change to linear mode via the general properties panel and get a warning that annotations will be truncated		`Output` `Screenshots` `Video`
properties > we should be able to view and edit a description in general properties and have that visible within the genbank view as well we should be able to edit a description in general properties, not make any changes, hit ok, and have the description not clear (bug! https://github.com/TeselaGen/lims/issues/5492) // and have that visible within the genbank view as well		`Output` `Screenshots` `Video`
properties > can click into the orf properties tab and change the minimum orf size and trigger a warning in the editor		`Output` `Screenshots` `Video`
properties > can view the orf properties checkboxes even when the window height is small		`Output` `Screenshots` `Video`
properties > -can select all in the genbank properties window //todo -has a Part 0 in the genbank		`Output` `Screenshots` `Video`
properties > can right click multiple of the same cutsite type (FokI) and have the cutsite properties table jump to the correct cutsite		`Output` `Screenshots` `Video`

The first 5 failed specs are shown, see all 56 specs in Cypress Cloud.

_{This comment has been generated by cypress-bot as a result of this
project's GitHub integration settings.}

cypress[bot] commented 1 year ago

243 failed tests on run #1596 ↗︎

243

15

1

12

0

Details:

Merge 8ce49c4aaff5beab76836700db5ba87d9b278520 into ff7e59dd9eb9eef54da11d0d50e2...
Project: openVectorEditor	Commit: `a53a0961e9 ℹ️`
Status: Failed	Duration: 11:59 💡
Started: Mar 21, 2023 6:02 PM	Ended: Mar 21, 2023 6:14 PM

editor.spec.js • 33 failed tests

View Output Video

Test		Artifacts
editor > annotation limits should persist across reloads and be configurable from the menu		`Output` `Screenshots` `Video`
editor > annotation limits should not show up as options if maxAnnotationsToDisplay is passed		`Output` `Screenshots` `Video`
editor > should be able to hide the rotate circular view!		`Output` `Screenshots` `Video`
editor > should be able to hide the zoom circular view!		`Output` `Screenshots` `Video`
editor > should be able to hide the single import button if necessary!		`Output` `Screenshots` `Video`
editor > should be able to set visibilities!		`Output` `Screenshots` `Video`
editor > should fire the rename handler		`Output` `Screenshots` `Video`
editor > should fire the onSelectionOrCaretChanged handler		`Output` `Screenshots` `Video`
editor > should allow you to view, but not edit features/parts/primers when in read only mode		`Output` `Screenshots` `Video`
editor > you should not be able to change editability of a sequence when disableSetReadOnly=true		`Output` `Screenshots` `Video`
The first 10 failed tests are shown, see all 33 tests in Cypress Cloud.

menuBar.spec.js • 21 failed tests

View Output Video

Test		Artifacts
menuBar > fivePrimeThreePrimeHints should be toggleable		`Output` `Screenshots` `Video`
menuBar > Should be able to hide individual features		`Output` `Screenshots` `Video`
menuBar > Should be able to hide individual parts		`Output` `Screenshots` `Video`
menuBar > Should be able to filter features by length		`Output` `Screenshots` `Video`
menuBar > Should be able to filter part by length		`Output` `Screenshots` `Video`
menuBar > Should be able to change circular/linear from the menu bar		`Output` `Screenshots` `Video`
menuBar > should be able to use the search/shortcut bar to translate the sequence		`Output` `Screenshots` `Video`
menuBar > should be able to change the amino acid color (by hydrophobicity or by family)		`Output` `Screenshots` `Video`
menuBar > should be able to permanently change sequence case		`Output` `Screenshots` `Video`
menuBar > should be able to permanently change selected sequence case		`Output` `Screenshots` `Video`
The first 10 failed tests are shown, see all 21 tests in Cypress Cloud.

findTool.spec.js • 10 failed tests

View Output Video

Test		Artifacts
find tool > the find tool shouldn't get stuck in a weird state where the match number is greater than the number of matches		`Output` `Screenshots` `Video`
find tool > when there is only 1 search result, typing enter in the find tool should jump you back to the search layer		`Output` `Screenshots` `Video`
find tool > when there is only 2 search results but the search is palindromic, typing enter in the find tool should jump you back to the search layer		`Output` `Screenshots` `Video`
find tool > can be expanded and should have full functionality as such		`Output` `Screenshots` `Video`
find tool > find parts/primers/features		`Output` `Screenshots` `Video`
find tool > have clickable find layers		`Output` `Screenshots` `Video`
find tool > reverse strand matches should cause annotations created from right click to be in reverse direction		`Output` `Screenshots` `Video`
find tool > reverse strand matches should cause annotations created from click and then subsequent create to be in reverse direction		`Output` `Screenshots` `Video`
find tool > clear search layers when closed and retain the previous search and be selected when re-opened		`Output` `Screenshots` `Video`
find tool > -it starts with nothing selected -it can find dna letters -it can toggle the find options and highlight all -and toggle finding Amino acids		`Output` `Screenshots` `Video`

editing.spec.js • 9 failed tests

View Output Video

Test		Artifacts
editing > editing a part/feature and saving shouldn't make the new part/feature window initialize in edit mode		`Output` `Screenshots` `Video`
editing > should return focus correctly after typing in chars in circular view		`Output` `Screenshots` `Video`
editing > should return focus correctly after typing in chars in row view		`Output` `Screenshots` `Video`
editing > should be able to delete data around the origin correctly - the cursor should be placed at the origin		`Output` `Screenshots` `Video`
editing > should be able to insert data around the origin correctly - new sequence should be inserted after the origin		`Output` `Screenshots` `Video`
editing > should be able to revComp, comp selections that wrap the origin correctly - new sequence should be inserted after the origin		`Output` `Screenshots` `Video`
editing > should be able to change the color of features by changing the feature type		`Output` `Screenshots` `Video`
editing > should be able to edit a feature/part via double clicking		`Output` `Screenshots` `Video`
editing > should be able to edit a feature/part start/end by clicking/dragging in the editor		`Output` `Screenshots` `Video`

properties.spec.js • 9 failed tests

View Output Video

Test		Artifacts
properties > creating a primer should create a primer in the genbank at the selected range		`Output` `Screenshots` `Video`
properties > should be able to delete a feature from the properties tab and not have the delete button still enabled; - have the number of features correctly displayed -not be able to create a new feature if sequenceLength === 0		`Output` `Screenshots` `Video`
properties > a custom properties tab should be able to be added		`Output` `Screenshots` `Video`
properties > can change to linear mode via the general properties panel and get a warning that annotations will be truncated		`Output` `Screenshots` `Video`
properties > we should be able to view and edit a description in general properties and have that visible within the genbank view as well we should be able to edit a description in general properties, not make any changes, hit ok, and have the description not clear (bug! https://github.com/TeselaGen/lims/issues/5492) // and have that visible within the genbank view as well		`Output` `Screenshots` `Video`
properties > can click into the orf properties tab and change the minimum orf size and trigger a warning in the editor		`Output` `Screenshots` `Video`
properties > can view the orf properties checkboxes even when the window height is small		`Output` `Screenshots` `Video`
properties > -can select all in the genbank properties window //todo -has a Part 0 in the genbank		`Output` `Screenshots` `Video`
properties > can right click multiple of the same cutsite type (FokI) and have the cutsite properties table jump to the correct cutsite		`Output` `Screenshots` `Video`

The first 5 failed specs are shown, see all 56 specs in Cypress Cloud.

_{This comment has been generated by cypress-bot as a result of this
project's GitHub integration settings.}

TeselaGen / openVectorEditor

Mobx refactor #883

Codecov Report

243 failed tests on run #1597 ↗︎

243 failed tests on run #1596 ↗︎