TeselaGen / openVectorEditor

DEPRECATED - Teselagen's Open Source Vector/Plasmid Editor Component
https://teselagen.github.io/tg-oss/ove/#/Editor
MIT License
200 stars 72 forks source link

ssDNA should not show reverseSequence automaticlly #898

Closed XingGao-PKI closed 1 year ago

XingGao-PKI commented 1 year ago

With this change and https://github.com/TeselaGen/tg-oss/pull/1 Reversed sequence does not show when drag a ss-DNA file in.

image
cypress[bot] commented 1 year ago

4 failed tests on run #1652 ↗︎

4 266 1 0 Flakiness 0

Details:

Merge 1a466f5af0fdd9bc3aa0f053b66a736f06841988 into 7fe072d790413e536e7b1ff84081...
Project: openVectorEditor Commit: dad24945cc ℹ️
Status: Failed Duration: 11:49 💡
Started: Jun 28, 2023 6:05 AM Ended: Jun 28, 2023 6:16 AM
Failed  menuBar.spec.js • 2 failed tests View Output Video
Test Artifacts
menuBar > should be able to use the search/shortcut bar to translate the sequence Output Screenshots
menuBar > should be able to change the amino acid color (by hydrophobicity or by family) Output Screenshots
Failed  enzymeManager.spec.js • 1 failed test View Output Video
Test Artifacts
enzymeManager > enzymes not shown by default should show up when added to a group (and hiding an enzyme that is shown in a group should work) Output Screenshots
Failed  umdDemo.spec.js • 1 failed test View Output Video
Test Artifacts
umd demo > the umd demo should load and show the editors Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

XingGao-PKI commented 1 year ago

@tnrich could you check this and https://github.com/TeselaGen/tg-oss/pull/1. Any concerns you can comment here.

tnrich commented 12 months ago

@XingGao-PKI it looks like adding annotationVisibilityUpdated to the isAlreadySpecialEditor causes translations to not show up on the default sequence and broke a few tests

This code in particular:

image

Broke these tests -

image

https://cloud.cypress.io/projects/mp89gp/runs/1654/overview?roarHideRunsWithDiffGroupsAndTags=1

I'm going to revert that part of your change from ove. Can you explain why you added that code?

XingGao-PKI commented 12 months ago

if you init the editor with a SS-DNA, it will be fine, but if you pull one ss-DNA to ds-DNA borad, we need to update the reverseSequence. it's OK you reverted this part, I will check if we have another way to change it.