Closed XingGao-PKI closed 1 year ago
![]() |
![]() |
![]() |
![]() |
![]() |
Details:
Merge 1a466f5af0fdd9bc3aa0f053b66a736f06841988 into 7fe072d790413e536e7b1ff84081... | |||
Project: openVectorEditor | Commit: dad24945cc ℹ️ |
||
Status: Failed | Duration: 11:49 💡 | ||
Started: Jun 28, 2023 6:05 AM | Ended: Jun 28, 2023 6:16 AM |
View
Output
Video
View
Output
Video
Test | Artifacts | |
---|---|---|
enzymeManager > enzymes not shown by default should show up when added to a group (and hiding an enzyme that is shown in a group should work) |
Output
Screenshots
|
View
Output
Video
Test | Artifacts | |
---|---|---|
umd demo > the umd demo should load and show the editors |
Output
Screenshots
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
@tnrich could you check this and https://github.com/TeselaGen/tg-oss/pull/1. Any concerns you can comment here.
@XingGao-PKI it looks like adding annotationVisibilityUpdated
to the isAlreadySpecialEditor
causes translations to not show up on the default sequence and broke a few tests
This code in particular:
Broke these tests -
https://cloud.cypress.io/projects/mp89gp/runs/1654/overview?roarHideRunsWithDiffGroupsAndTags=1
I'm going to revert that part of your change from ove. Can you explain why you added that code?
if you init the editor with a SS-DNA, it will be fine, but if you pull one ss-DNA to ds-DNA borad, we need to update the reverseSequence
. it's OK you reverted this part, I will check if we have another way to change it.
With this change and https://github.com/TeselaGen/tg-oss/pull/1 Reversed sequence does not show when drag a ss-DNA file in.