Direction of features in genebank file not taken into account

TeselaGen / openVectorEditor

DEPRECATED - Teselagen's Open Source Vector/Plasmid Editor Component

https://teselagen.github.io/tg-oss/ove/#/Editor

MIT License

200 stars 72 forks source link

Direction of features in genebank file not taken into account #901

Closed MarcelBolten closed 1 year ago

MarcelBolten commented 1 year ago

Hi Thomas @tnrich

It seems like ove does not take into account the direction of features in a genebank file. An eLabFTW user made us aware of this behaviour (https://github.com/elabftw/elabftw/issues/4465). Is this a real bug or a configuration issue on our side?

An example file would be pUC18 from addgene https://media.addgene.org/snapgene-media/v1.7.9-0-g88a3305/sequences/74675/64749fcd-6f9c-4527-a4f5-ed40d26e4ea9/addgene-plasmid-50004-sequence-74675.dna

MarcelBolten commented 1 year ago

Hi @tnrich any ideas about this issue?

tnrich commented 1 year ago

@MarcelBolten probably an issue in the .dna parser (not the genbank parser). That is located here in the @teselagen/bio-parsers package - https://github.com/TeselaGen/tg-oss/tree/main/packages/bio-parsers

Please add a failing test there for the .dna parser and try to fix. I can help fix if you're not able to.. I'm not super familiar with the .dna format in general so it might be a bit of a struggle.

MarcelBolten commented 1 year ago

Thank you. So far it seems to be working as expected.