TeselaGen / openVectorEditor

DEPRECATED - Teselagen's Open Source Vector/Plasmid Editor Component
https://teselagen.github.io/tg-oss/ove/#/Editor
MIT License
200 stars 72 forks source link

Read only #911

Closed jgespinosa10 closed 1 year ago

jgespinosa10 commented 1 year ago

Added tooltip dialogue when edit lock is disabled. Added onChangeEditLock parameter. It is a function that runs when the editLock button is pressed, it receives the value of readOnly that you are changing into: onChangeEditLock(!readOnly);

tnrich commented 1 year ago

@jgespinosa10 you'll need to remake this PR here - https://github.com/TeselaGen/tg-oss/tree/main/packages/ove

This repo has been deprecated

cypress[bot] commented 1 year ago

3 failed tests on run #1719 ↗︎

3 267 1 0 Flakiness 0

Details:

onChangeEditLock
Project: openVectorEditor Commit: cadf07c9e3
Status: Failed Duration: 12:29 💡
Started: Jul 28, 2023 8:49 PM Ended: Jul 28, 2023 9:02 PM
Failed  autoAnnotate.spec.js • 1 failed test View Output Video
Test Artifacts
autoAnnotate > auto annotating parts should work when the csv file doesn't have a 'type' column Output Screenshots
Failed  rnaMode.spec.js • 1 failed test View Output Video
Test Artifacts
rna editing in OVE > should support mixed rna and dna editing Output Screenshots
Failed  umdDemo.spec.js • 1 failed test View Output Video
Test Artifacts
umd demo > the umd demo should load and show the editors Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

codecov-commenter commented 1 year ago

Codecov Report

Merging #911 (cadf07c) into master (453ce25) will increase coverage by 0.00%. The diff coverage is 76.19%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #911   +/-   ##
=======================================
  Coverage   74.84%   74.85%           
=======================================
  Files         291      291           
  Lines       11295    11301    +6     
  Branches     4074     4075    +1     
=======================================
+ Hits         8454     8459    +5     
- Misses       2490     2491    +1     
  Partials      351      351           
Files Changed Coverage Δ
src/redux/readOnly.js 28.57% <0.00%> (ø)
src/ToolBar/editTool.js 76.92% <72.72%> (-23.08%) :arrow_down:
src/Editor/index.js 78.04% <88.88%> (ø)

... and 3 files with indirect coverage changes

cypress[bot] commented 1 year ago

3 failed tests on run #1720 ↗︎

3 267 1 0 Flakiness 0

Details:

Merge cadf07c9e3645c2b8f4ad533ab46d7da36296f68 into 453ce25d1d9b1ec611508b50bde3...
Project: openVectorEditor Commit: cf3efda784 ℹ️
Status: Failed Duration: 13:43 💡
Started: Jul 28, 2023 9:01 PM Ended: Jul 28, 2023 9:15 PM
Failed  menuBar.spec.js • 1 failed test View Output Video
Test Artifacts
menuBar > should be able to open the hotkeys dialog Output Screenshots
Failed  editing.spec.js • 1 failed test View Output Video
Test Artifacts
editing > should be able to insert data around the origin correctly - new sequence should be inserted after the origin Output Screenshots
Failed  umdDemo.spec.js • 1 failed test View Output Video
Test Artifacts
umd demo > the umd demo should load and show the editors Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.