TeselaGen / tg-oss

Teselagen Open Source modules
https://teselagen.github.io/tg-oss/
MIT License
37 stars 18 forks source link

Few changes to CONTRIBUTING and README #53

Closed NicolasCARPi closed 6 months ago

NicolasCARPi commented 8 months ago

Hello,

Here are a few changes that I believe would improve slightly the DX:

I don't know what to do with this auto changelog thing, sorry. But if there is a special git command to avoid generating it, we'll want to add it to the freshly improved CONTRIBUTING documentation ;) IMHO it should only run before making a release, no?

tnrich commented 6 months ago

Hi @NicolasCARPi sorry I didn't see this one till now. I've updated the PR template to include an @tnrich tag so I'll hopefully be notified of incoming PRs sooner in the future. Thanks for your changes, they look good. I'll poke around to see if I can get the changelog to only be run on version bumps.

Cheers!

NicolasCARPi commented 6 months ago

Hello,

Thanks for merging. Why don't you use the "Watch" function of github? Seems getting notifications for all activity on this repo make sense, no?

tnrich commented 6 months ago

@NicolasCARPi I wasn't sure where that toggle lived, thanks! I've updated my watch status to All Activity.

Cheers!