search

TeselaGen / tg-oss

Teselagen Open Source modules
https://teselagen.github.io/tg-oss/
MIT License
37 stars 18 forks source link

ove tippy styles override those defined via tippy theme #60

Closed ryan-stackwave closed 4 months ago

ryan-stackwave commented 5 months ago

Tippy styles for ove need to be defined with a narrower scope as they are overriding the base tippy styles and breaking the ability to use themes:

https://github.com/TeselaGen/tg-oss/blob/bd9119527e5cd7d6e9736747a24b85bb25482df1/packages/ui/src/style.css#L176

@tnrich

tnrich commented 5 months ago

What CSS are you trying to apply @ryan-stackwave? Also do you have a recommended fix for this codebase?

Thanks!

tnrich commented 4 months ago

@ryan-stackwave bump :)

ryan-stackwave commented 4 months ago

Sorry @tnrich, got caught up with other things. Here's a jsfiddle demonstrating the issue: https://jsfiddle.net/6qd3owpt/ If you delete the ove stylesheet you'll see that the tooltip for the button responds to the configured "light" theme.

I think we would probably be best served by creating a tippy theme for this project to narrow the scope of these styles to the tippy instances used inside this project. Want me to take a crack?

tnrich commented 4 months ago

Sure! Basically anything that allows us to keep the tippy styles looking like they currently do within our project should be fine! Thanks for looking into this!