Error when clicking "+ Add Note" when creating a new feature

TeselaGen / tg-oss

Teselagen Open Source modules

https://teselagen.github.io/tg-oss/

MIT License

37 stars 18 forks source link

Error when clicking "+ Add Note" when creating a new feature #63

Closed ryan-stackwave closed 4 months ago

ryan-stackwave commented 4 months ago

The error is: ResizeObserver loop completed with undelivered notifications.

To reproduce: Enable editing -> Highlight sequence -> Right-click -> Create -> New Feature -> + Add Note

https://jsfiddle.net/zah72dnm/3/

@tnrich

tnrich commented 4 months ago

I can't seem to reproduce @ryan-stackwave :

not sure why?

Can you send a video of you triggering it maybe?

ryan-stackwave commented 4 months ago

@tnrich it doesn't seem to error if the "New Feature" modal already has a vertical scrollbar so try giving yourself enough vertical window for the entire modal to display.

tnrich commented 4 months ago

Hmm @ryan-stackwave I tried again with no scrollbar and still couldn't get the error to occur I don't think:

Thoughts?

ryan-stackwave commented 4 months ago

@tnrich very strange, it's happening for me in both firefox and chrome:

tnrich commented 4 months ago

Is this breaking anything for you @ryan-stackwave or just showing up as an error?

ryan-stackwave commented 4 months ago

@tnrich this came up in our testing because we popup a message to the user whenever there are javascript errors. However, I can probably swallow any errors that come out of ove as a workaround.

tnrich commented 4 months ago

@ryan-stackwave I wouldn't swallow all the ove errors but this might be one of the ones you'll need to..

ryan-stackwave commented 4 months ago

@tnrich Debouncing the ResizeObserver callback seems to resolve the issue. Please let me know if you think that's a reasonable approach. https://github.com/TeselaGen/tg-oss/pull/65