search

TeselaGen / tg-oss

Teselagen Open Source modules
https://teselagen.github.io/tg-oss/
MIT License
39 stars 18 forks source link

With multiple vector editors, resizing the browser window while the "New Feature" dialog is open causes another disabled dialog to open #66

Closed ryan-stackwave closed 4 months ago

ryan-stackwave commented 7 months ago

Open the New Feature dialog and then resize the browser window. https://jsfiddle.net/wzbdf1ar/

@tnrich

tnrich commented 7 months ago

Hmm yep able to reproduce this.. Not sure what's going on here.

tnrich commented 4 months ago

@ryan-stackwave sorry haven't had time to look into this one. Any chance you've been able to dig into it?

tnrich commented 4 months ago

Ok, I think I've made a fix for this issue @ryan-stackwave

Basically I'm adding an editorName prop to the dialogHolder singleton that powers the GlobalDialog component by querying the activeElement's editorName when the showDialog() function is triggered. That should hopefully allow the GlobalDialog component that lives in the Editor component to be more selective if another editor has fired the dialog in question.

Released in v0.5.5

tnrich commented 4 months ago

Lemme know if this still isn't working and I can re-open. Cheers!