search

TeselaGen / tg-oss

Teselagen Open Source modules
https://teselagen.github.io/tg-oss/
MIT License
37 stars 18 forks source link

Resolving warnings of deprecated react apis #75

Open smeng9 opened 2 months ago

smeng9 commented 2 months ago

@tnrich

React 19 is going to remove deprecated apis.

It seems there are still cases that we are using old apis like findDOMNode and render

Also do you know why this commit https://github.com/TeselaGen/tg-oss/commit/7b8fcbf434ffd40eb00f876ef90e8cfe88e6a5e4#diff-0d834dfe0b1aa1cb2ec5a918b1fee8f2346ca411fcaec907ebe0b1a6d2754b4e is reverted. Is it causing some issues?

tnrich commented 2 months ago

Hi @smeng9 yes that commit was causing quite a few legitimate test failures in cypress so I went ahead and rolled it back.