Teshynil / combatready

Combat ready indicator to remind players of their turn, as well as time taken.
GNU General Public License v3.0
5 stars 1 forks source link

No alerts in v10 build 286 D&D 5e #21

Closed Rouros closed 1 year ago

Rouros commented 2 years ago

On a fresh world with only this module installed I see the timer bar at the bottom, and hear the new round whoosh, but no alerts are given for next player or its your turn.

Tests work fine in the config screen though.

Rouros commented 2 years ago

I did my testing on a local machine running the latest update of Combat ready. 4.2.0

Teshynil commented 2 years ago

Hi @Rouros, as the GM you are not show the alerts, only the players can see them, test in a incognito window connected as player if the problem replicates let me know sharing a copy of the console log

Rouros commented 2 years ago

yup I connected as a player and didn't see anything. I was running these tests as I was playing with my group and it didn't work for them either. So I set up a test world, logged in as GM in the foundry client and a player in a browser window. Same result.

Teshynil commented 2 years ago

Could you share the console log and which modules have active

Rouros commented 2 years ago

There are no other modules active. Console below. I ran a couple of combat rounds and this log is from a combatant taking part in the encounter,

Rouros commented 2 years ago

127.0.0.1-1664631691309.log

Rouros commented 2 years ago

I also see this in setup Screenshot 2022-10-01 144821

Teshynil commented 2 years ago

I also see this in setup Screenshot 2022-10-01 144821

This is because the module is using both v9 and v10 declarations to make it compatible with both

Teshynil commented 2 years ago

127.0.0.1-1664631691309.log

I will check that

sashemi commented 1 year ago

I am NOT replicating this on Foundry 10.291 with DND5e 2.1.5.

NEXT UP and YOUR TURN alerts are indeed showing on screen for the player, as expected.