Limit the check for the extension to last 5 letters

TeskaLabs / asab

Asynchronous Server App Boilerplate (ASAB) is a micro-service framework for Python 3 and asyncio.

https://docs.teskalabs.com/asab/

BSD 3-Clause "New" or "Revised" License

29 stars 7 forks source link

Limit the check for the extension to last 5 letters #557

Open ateska opened 6 months ago

ateska commented 6 months ago

The zookeeper library provider detects if the item is a file (not folder) by scanning for "." character. This MUST be limited to last 5 characters, so that users can put "." in the middle of the long name of the file without an issue.

https://github.com/TeskaLabs/asab/blob/22654362e376df49fdaf55833cd566e26a2c4cea/asab/library/providers/zookeeper.py#L271C4-L271C56

ateska commented 5 months ago

@mithunbharadwaj is this still open?

mejroslav commented 1 week ago

@mithunbharadwaj Is this one solved already? If so, can you please attach the corresponding MR and close this issue?

mithunbharadwaj commented 2 days ago

@mejroslav Solved here https://github.com/TeskaLabs/asab/pull/558