TeslaBuds / AuthAppForTesla

54 stars 13 forks source link

Refresh #10

Closed TeslaOwnerTips closed 3 years ago

TeslaOwnerTips commented 3 years ago

The refresh button no longer does anything. Thank you for the app.

Kemmey commented 3 years ago

It should refresh your access token - you can see that it has refreshed by the token validity resetting to 8 hours.

Usually you should not need to tap refresh at all though - this happens automatically - even when using the shortcuts actions

Cheers,

Kim

TeslaOwnerTips commented 3 years ago

Before and after “Refresh Token” (Image removed)

Kemmey commented 3 years ago

Please don't post tokens online :-D

Is this the access token or the refresh token? The refresh token almost never change, and certainly not when tapping refresh tokens :-D

TeslaOwnerTips commented 3 years ago

It’s not the entire token. Is there still a way to revoke tokens other than charging the Tesla account password?

Kemmey commented 3 years ago

No - unfortunately not - still waiting for Tesla to implement and expose proper OAuth where we'll be able to register out applications and reply urls. When they do - this app can happily be decommissioned :-D

Kemmey commented 3 years ago

But I suspect your screenshots above were for the refresh token, right? They don't change at refresh - I've rarely seen them change. I'm not sure they even have an expiration time. But access tokens properly change - also when manually refreshing - have triple checked and confirmed.

TeslaOwnerTips commented 3 years ago

Okay thanks. It said Refresh Tokens plural.

Kemmey commented 3 years ago

Oh - it DOES refresh all three tokens - it refreshes the refresh token, the v3 access token and the v2 access token (no longer exposed in ui as it is considered deprecated - still accessible via shortcuts.

But the refresh token very rarely changes - during a refresh it is the server that controls what to send back - if server does not deem it necessary to issue a new refresh token - you will just get the old one back. That does not mean it is not refreshed...