search

TeslaGov / ngx-http-auth-jwt-module

Secure your NGINX locations with JWT
MIT License
308 stars 118 forks source link

Publish source for build with current nginx? #114

Open lukepalmer opened 7 months ago

lukepalmer commented 7 months ago

Hello- thanks for the great module!

I noticed that 2.0.2 does not build against current stable nginx, and that there was probably a breaking change due to https://github.com/nginx/nginx/commit/3aef1d693f3cc431563a7e6a6aba6a34e5290f03.

I think this must be solved in code that isn't published, and also that this may be the reason for multiple binary assets being published along with the most recent release.

I do need to build from source for my usage. Would it be possible to publish these changes? Thank you!

JoshMcCullough commented 7 months ago

Current stable NGINX is 1.24.0 -- the module builds fine for that version, as well as the current mainline version (1.25.3).

Can you elaborate on the issue you're seeing?

JoshMcCullough commented 7 months ago

And yes, the headers changes were a breaking change but that was applied to the module's code long ago.

lukepalmer commented 7 months ago

Ah I see it now. The Dockerfile sets a build flag to have this work: BUILD_FLAGS="${BUILD_FLAGS} --with-cc-opt='-DNGX_LINKED_LIST_COOKIES=1'"

Because I am building from source and not using docker I need to set this myself. So if anything this is a very minor documentation issue.

Thanks for the quick response!

bugsmafia commented 4 months ago

for version nginx 1.25.4 - update pls

JoshMcCullough commented 4 months ago

@bugsmafia are you requesting we release binaries for NGINX v1.25.4? I built it just for you, you can find it here: https://github.com/TeslaGov/ngx-http-auth-jwt-module/releases/tag/2.0.3