search

TeslaGov / ngx-http-auth-jwt-module

Secure your NGINX locations with JWT
MIT License
310 stars 119 forks source link

RSA Key Support #27

Closed TimUnderhay closed 6 years ago

TimUnderhay commented 6 years ago

Am I correct in stating that this module currently supports only symmetric keys, but not asymmetric RSA private key-signed tokens? If so, I would like to make a feature request to support tokens signed by RSA keys.

I'm specifically looking for RS256.

Thank you!

fitzyjoe commented 6 years ago

Yes, this currently only supports symmetric keys. libjwt, the C library I'm using under the covers supports asymmetric keys so it would be possible to enhance this module and continue to use libjwt. I don't have a business need at the moment for this, but I would welcome a pull request.

TimUnderhay commented 6 years ago

Hey Fitzyjoe, I totally understand about not having a business need. I've just sent a pull request with the RSA validation functionality.

TimUnderhay commented 6 years ago

Closing as PR has been merged. Thanks, @fitzyjoe!

kevinmichaelchen commented 6 years ago

For posterity: see #31