TeslaGov / ngx-http-auth-jwt-module

Secure your NGINX locations with JWT
MIT License
309 stars 118 forks source link

Slight performance improvement for RSA auth + MacOS build fix #32

Closed TimUnderhay closed 6 years ago

TimUnderhay commented 6 years ago

I've got another small update for you. And this time I've got Docker set up on my build host so the .so is good. Hopefully you should be able to just merge.

Removed memcpy op for RSA validation and use pointer instead. build.sh fix for MacOS Docker.

TimUnderhay commented 6 years ago

I admit that it’s strange and didn’t make sense to me, but that was the guidance from a Docker issue (have to find it), and it worked perfectly for me.

TimUnderhay commented 6 years ago

https://github.com/prakhar1989/docker-curriculum/issues/27

kevinmichaelchen commented 6 years ago

It's out of scope for this PR, but it'd probably be better to run the curl commands from inside a container and hit http://host.docker.internal:8000...

e.g,.

docker run --rm byrnedo/alpine-curl --silent http://host.docker.internal:8000

https://stackoverflow.com/questions/24319662/from-inside-of-a-docker-container-how-do-i-connect-to-the-localhost-of-the-mach/24326540#24326540