TeslaGov / ngx-http-auth-jwt-module

Secure your NGINX locations with JWT
MIT License
309 stars 118 forks source link

Dockerize tests #44

Closed kevinmichaelchen closed 5 years ago

kevinmichaelchen commented 6 years ago

Recent pull requests have debated (see here and here) what MACHINE_IP should be in test.sh.

Why not use Docker and forget about the intricacies of making tests cross-platform? Isn't that what Docker is for?

Everything is now 100% Docker-ized. Tests can be run just by running make. To rebuild the module, run make rebuild-nginx. To rebuild the test image, run make rebuild-test-runner.

kevinmichaelchen commented 6 years ago

@fitzyjoe @maxx-t @KensingtonTech does this work for you?

JoshMcCullough commented 5 years ago

I assume this can be closed @crain9412 / @fitzyjoe ?