search

TeslaGov / ngx-http-auth-jwt-module

Secure your NGINX locations with JWT
MIT License
317 stars 122 forks source link

Remove X- header prefix #45

Closed kevinmichaelchen closed 6 years ago

kevinmichaelchen commented 6 years ago

Custom proprietary headers can be added using the 'X-' prefix, but this convention was deprecated in June 2012, because of the inconveniences it caused when non-standard fields became standard in RFC-6648

Proposal

Add auth_jwt_header_prefix to allow users to specify custom header prefix.

e.g., 

auth_jwt_header_prefix "clarakm"

Then x-email and x-userid would be renamed to clarakm-email and clarakm-userid.

fitzyjoe commented 6 years ago

Please don’t change!

Sent from my iPhone

On Jun 12, 2018, at 12:17 PM, Kevin Chen notifications@github.com wrote:

Custom proprietary headers can be added using the 'X-' prefix, but this convention was deprecated in June 2012, because of the inconveniences it caused when non-standard fields became standard in RFC-6648

Proposal: Rename x-email and x-userid to clarakm-email and clarakm-userid.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

kevinmichaelchen commented 6 years ago

I won't change any code. Is it a valid issue?

kevinmichaelchen commented 6 years ago

This is too difficult of a task. It's not as simple as changing two strings. Closing.