search

TeslaGov / ngx-http-auth-jwt-module

Secure your NGINX locations with JWT
MIT License
308 stars 118 forks source link

Fix: Only call `docker rmi` if there are images to prune #85

Closed SmartArray closed 1 year ago

SmartArray commented 1 year ago

This PR modifies the build script so that docker rmi is only being called if the docker images --filter=label=stage=builder --quiet returns images at all.

This is important for CI environments because otherwise the build step would fail

SmartArray commented 1 year ago

Changed the call to return always true. Simpler and safer than using an if clause

JoshMcCullough commented 1 year ago

Thanks for the PR!

SmartArray commented 1 year ago

I have to say thanks for such a high-quality open source project. I always appreciate discovering projects like these. 🥇