Teslemetry / hass-teslemetry

Teslemetry integration from Home Assistant through HACS
https://teslemetry.com
MIT License
13 stars 7 forks source link

FR: don't force number entities UI presentation to be "box" #79

Closed fhteagle closed 6 months ago

fhteagle commented 6 months ago

Checklist

Is your feature request related to a problem? Please describe.

the number.mycar_charge_limit and number.mycar_charge_current are forced by code to be presented as a digital input box by the following line : https://github.com/Teslemetry/hass-teslemetry/blob/54b9da01b991320d1ce0ee405832735d406cf4fe/custom_components/teslemetry/number.py#L76

Describe the solution you'd like

However, the "slider" is much easier to use in my opinion, and that option is unlocked by not forcing the input to be a box. Consider changing this line to

mode=NumberMode.auto,

Which is in-line with recommended practice in HA documentation.

Additional context

Relevant HA entity documentation:

https://developers.home-assistant.io/docs/core/entity/number/

Bre77 commented 6 months ago

Done, will be in next release.